Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(176)

Issue 29356322: Issue 4501 - Fix treatment of element hiding filters with filter key 0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by Wladimir Palant
Modified:
3 years ago
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

I wonder whether I should again insist on banning the sloppy if (foo) coding style - treating 0, empty string and undefined the same is a footgun.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -134 lines) Patch
M lib/elemHide.js View 1 chunk +1 line, -1 line 0 comments Download
M test/elemHide.js View 1 chunk +143 lines, -133 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
3 years ago (2016-10-07 10:11:52 UTC) #1
kzar
3 years ago (2016-10-07 10:18:33 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5