Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(251)

Issue 29356341: Issue 4503 - ensure_dependencies.py fails for git submodule

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by anton
Modified:
1 year, 8 months ago
Reviewers:
Sebastian Noack
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 4503 - ensure_dependencies.py fails for git submodule

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M ensure_dependencies.py View 1 chunk +7 lines, -1 line 1 comment Download

Messages

Total messages: 10
anton
2 years, 10 months ago (2016-10-07 11:55:25 UTC) #1
anton
https://codereview.adblockplus.org/29356341/diff/29356342/ensure_dependencies.py File ensure_dependencies.py (right): https://codereview.adblockplus.org/29356341/diff/29356342/ensure_dependencies.py#newcode80 ensure_dependencies.py:80: _ensure_line_exists(ignore_path, module) probably should add try except here too
2 years, 10 months ago (2016-10-07 19:11:44 UTC) #2
Felix Dahlke
Please note that ensure_dependencies.py is being pulled from buildtools, so this has to be addressed ...
2 years, 10 months ago (2016-10-11 10:30:15 UTC) #3
Sebastian Noack
So as far as I understand, if in a git submodule, .git is not the ...
2 years, 10 months ago (2016-10-11 11:59:21 UTC) #4
anton
On 2016/10/11 11:59:21, Sebastian Noack wrote: > So as far as I understand, if in ...
2 years, 10 months ago (2016-10-11 12:20:47 UTC) #5
Sebastian Noack
On 2016/10/11 12:20:47, anton wrote: > On 2016/10/11 11:59:21, Sebastian Noack wrote: > > So ...
2 years, 10 months ago (2016-10-11 12:23:57 UTC) #6
anton
On 2016/10/11 12:23:57, Sebastian Noack wrote: > On 2016/10/11 12:20:47, anton wrote: > > On ...
2 years, 10 months ago (2016-10-11 13:03:25 UTC) #7
Sebastian Noack
On 2016/10/11 13:03:25, anton wrote: > On 2016/10/11 12:23:57, Sebastian Noack wrote: > > On ...
2 years, 10 months ago (2016-10-11 13:39:51 UTC) #8
Wladimir Palant
On 2016/10/11 12:20:47, anton wrote: > Sounds reasonable, what about Mercurial Subrepositories? What about them? ...
2 years, 10 months ago (2016-10-11 14:24:17 UTC) #9
anton
2 years, 10 months ago (2016-10-14 13:14:14 UTC) #10
On 2016/10/11 14:24:17, Wladimir Palant wrote:
> On 2016/10/11 12:20:47, anton wrote:
> > Sounds reasonable, what about Mercurial Subrepositories?
> 
> What about them? Mercurial subrepositories are no different than "regular"
> repositories, no special treatment should be necessary.
> 
> You are patching an outdated version of ensure_repositories.py, this isn't
even
> the current state of the libadblockplus repository. Please change the master
> copy in the buildtools repository, then propagate it via dependency updates
> (libadblockplus doesn't depend on buildtools directly so this requires
updating
> the dependency in adblockpluscore first, then updating adblockpluscore
> dependencies in libadblockplus).

i've replaced `ensure_dependencies.py` with the latest version from `buildtools`
repository and i can confirm the issue remains.
to be fixed properly (with Sebastian's solution) later.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5