Issue 4330 - Avoid suggesting huge URL filters

composer.postload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 24 matching lines @@
 
 // Last right click state stored for element blocking via the context menu.
 let lastRightClickEvent = null;
 let lastRightClickEventIsMostRecent = false;
 
 
 /* Utilities */
 
 function getFiltersForElement(element, callback)
 {
+  let src = element.getAttribute("src");
   ext.backgroundPage.sendMessage(
   {
     type: "composer.getFilters",
     tagName: element.localName,
     id: element.id,
-    src: element.getAttribute("src"),
+    src: src && src.length < 1000 && src,

[Sebastian Noack, 2016/10/14 17:32:32]

This expression is quite weird. Besides that it is hard to read, note that in
case src has more than 1000 characters you pass false which is not great. How
about this:

  src && src.length <= 1000 ? src : null

[kzar, 2016/10/14 17:48:58]

Yea you're right, it was pretty weird to be fair :p
Done.

     style: element.getAttribute("style"),
     classes: Array.prototype.slice.call(element.classList),
     urls: getURLsFromElement(element),
     mediatype: typeMap[element.localName],
     baseURL: document.location.href
   },
   response =>
   {
     callback(response.filters, response.selectors);
   });
@@ skipping 515 matching lines @@
             }
           });
         }
         break;
     }
   });
 
   if (window == window.top)
     ext.backgroundPage.sendMessage({type: "composer.ready"});
 }