Issue 4528 - Update StarSSL's timestamp URL

build_release.py

 #!/usr/bin/env python
 
 import sys, os, re, subprocess
 
 def print_usage():
   print >>sys.stderr, "Usage: %s release|devbuild SIGNING_KEY_FILE" % (os.path.basename(sys.argv[0]))
 
 if len(sys.argv) < 3:
   print_usage()
   sys.exit(1)
 
 basedir = os.path.dirname(os.path.abspath(sys.argv[0]))
 build_type = sys.argv[1]
 
 if not build_type in ["release", "devbuild"]:
   print_usage()
   sys.exit(2)
 
 key = sys.argv[2]
 
 def sign_command(*argv):
   return [
     "signtool.exe",
     "sign", "/v",
     "/d", "Adblock Plus",
     "/du", "https://adblockplus.org/",
     "/f", key,
-    "/tr", "http://www.startssl.com/timestamp"
+    "/tr", "http://timestamp.comodoca.com"

[sergei, 2016/10/14 14:57:58]

Just wonder, is there any difference between
http://timestamp.comodoca.com/rfc3161
and
http://timestamp.comodoca.com
?

[Oleksandr, 2016/10/14 17:08:16]

The difference is in the company behind the URL. Since our certificate is from
Comodo we would want to use their timestamp server as well. There is no sense in
using another thirdparty timeserver for this, especially since it can change
without us noticing, as we've witnessed. Other than that I think the protocol is
the same.

[sergei, 2016/10/14 17:53:09]

My URLs are for the same company but in the first URL path is /rfc3161.

[Oleksandr, 2016/10/14 18:13:22]

Oh. Understood your question now. Where is the /rfc3161 coming from? I only see
the one we use in the documentation. And it says that URL supports rfc3161.

   ] + list(argv)
 
 def sign(*argv):
   subprocess.check_call(sign_command(*argv))
 
 def read_macro_value(file, macro):
   handle = open(file, 'rb')
   for line in handle:
     match = re.search(r"^\s*#define\s+%s\s+\w?\"(.*?)\"" % macro, line)
     if match:
@@ skipping 23 matching lines @@
 
 installerParams = os.environ.copy()
 installerParams["VERSION"] = version
 subprocess.check_call(["nmake", "/A", "ia32", "x64"], env=installerParams, cwd=os.path.join(basedir, "installer"))
 sign(os.path.join(basedir, "installer", "build", "ia32", "adblockplusie-%s-multilanguage-ia32.msi" % version),
     os.path.join(basedir, "installer", "build", "x64", "adblockplusie-%s-multilanguage-x64.msi" % version))
 
 # If this fails, please check if InnoSetup is installed and added to you PATH
 signparam = " ".join(map(lambda p: "$q%s$q" % p if " " in p else p, sign_command("$f")))
 subprocess.check_call(["iscc", "/A", "/Ssigntool=%s" % signparam, "/Dversion=%s" % version, os.path.join(basedir, "installer", "src", "innosetup-exe", "64BitTwoArch.iss")])