Issue 4525 - Filter Preferences: Move findbar to the top of the filters list

chrome/content/ui/filters-filterview.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 444 matching lines @@
       this.data.splice(position, 1);
       this.boxObject.rowCountChanged(position, -1);
       FilterView.addDummyRow();
 
       this.selectRow(position);
     }
   },
 
   /**
    * Selects a row in the tree and makes sure it is visible.
+   * @param {number} row
+   *   row index
+   * @param {boolean} [scrollToTop]
+   *   if true, the selected row should become the top row of the list if
+   *   possible, otherwise the list is only scrolled if the row isn't visible.
    */
-  selectRow: function(row)
+  selectRow: function(row, scrollToTop)
   {
     if (this.selection)
     {
       row = Math.min(Math.max(row, 0), this.data.length - 1);
       this.selection.select(row);
-      this.boxObject.ensureRowIsVisible(row);
+      if (scrollToTop)
+        this.boxObject.scrollToRow(row);
+      else
+        this.boxObject.ensureRowIsVisible(row);
     }
   },
 
   /**
    * Finds a particular filter in the list and selects it.
    */
   selectFilter: function(/**Filter*/ filter)
   {
     let index = -1;
     for (let i = 0; i < this.data.length; i++)
     {
       if (this.data[i].filter == filter)
       {
         index = i;
         break;
       }
     }
     if (index >= 0)
     {
-      this.selectRow(index);
+      this.selectRow(index, true);

[Wladimir Palant, 2016/10/14 08:12:12]

Selecting a filter (typically when coming from blockable items) is another
scenario where it makes sense to have the selection at the top of the list.

       this.treeElement.focus();
     }
   },
 
   /**
    * Updates value of data property on sorting or filter subscription changes.
    */
   updateData: function()
   {
     let oldCount = this.rowCount;
@@ skipping 331 matching lines @@
   getProgressMode: () => null,
   getImageSrc: () => null,
   isSeparator: () => false,
   performAction: () => {},
   performActionOnRow: () => {},
   performActionOnCell: () => {},
   getCellValue: () => null,
   setCellValue: () => {},
   selectionChanged: () => {}
 };