Issue 4525 - Filter Preferences: Move findbar to the top of the filters list

chrome/content/ui/filters-search.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 76 matching lines @@
     let text = E("findbar-textbox").value.trim();
     if (!text)
       return "";
 
     let caseSensitive = E("findbar-case-sensitive").checked;
 
     if (typeof direction == "undefined")
       direction = (text == this.lastSearchString ? 1 : 0);
     this.lastSearchString = text;
 
-    function normalizeString(string)
-    {
-      return caseSensitive ? string : string.toLowerCase();
-    }
+    let normalizeString = (caseSensitive ?
+                           string => string :
+                           string => string.toLowerCase());

[Wladimir Palant, 2016/10/14 08:12:12]

Unrelated change but I realized that this can be faster.

 
     function findText(startIndex)
     {
       let list = E("filtersTree");
       let col = list.columns.getNamedColumn("col-filter");
       let count = list.view.rowCount;
       for (let i = startIndex + direction; i >= 0 && i < count; i += (direction || 1))
       {
         let filter = normalizeString(list.view.getCellText(i, col));
         if (filter.indexOf(text) >= 0)
         {
-          FilterView.selectRow(i);
+          FilterView.selectRow(i, true);
           return true;
         }
       }
       return false;
     }
 
     text = normalizeString(text);
 
     // First try to find the entry in the current list
     if (findText(E("filtersTree").currentIndex))
@@ skipping 60 matching lines @@
   search: function(direction)
   {
     E("findbar").setAttribute("data-status", this._search(direction));
   }
 };
 
 window.addEventListener("load", event =>
 {
   E("findbar").setAttribute("data-os", Services.appinfo.OS.toLowerCase());
 });