Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/filters.xul

Issue 29357368: Issue 4525 - Filter Preferences: Move findbar to the top of the filters list (Closed) Base URL: https://hg.adblockplus.org/adblockplus
Patch Set: Created Oct. 14, 2016, 8:09 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/content/ui/filters-filterview.js » ('j') | chrome/content/ui/filters-filterview.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/filters.xul
===================================================================
--- a/chrome/content/ui/filters.xul
+++ b/chrome/content/ui/filters.xul
@@ -339,16 +339,28 @@
<menuitem label="&filter.moveDown.label;" key="moveDown-key" command="filters-moveDown-command"/>
<menuseparator/>
<menu id="viewMenu" label="&viewMenu.label;"/>
</menupopup>
</button>
<button id="addFilterButton" label="&addFilter.label;" command="filters-add-command"/>
</hbox>
+ <hbox id="findbar" hidden="true" align="center" onkeypress="FilterSearch.keyPress(event);">
+ <toolbarbutton id="findbar-closebutton" tooltiptext="&findbar.close;" oncommand="FilterSearch.close();"/>
+ <textbox id="findbar-textbox" type="search" placeholder="&findbar.placeholder;" flex="1" oncommand="FilterSearch.search();"/>
+ <spinbuttons id="findbar-findAgain" onup="FilterSearch.search(-1);" ondown="FilterSearch.search(1);"/>
+ <button id="findbar-case-sensitive" type="checkbox" label="&findbar.caseSensitive;" oncommand="FilterSearch.search(0);"/>
+ <stack>
+ <label id="findbar-status-wrappedStart" class="findbar-status" value="&findbar.statusWrappedStart;"/>
+ <label id="findbar-status-wrappedEnd" class="findbar-status" value="&findbar.statusWrappedEnd;"/>
+ <label id="findbar-status-notFound" class="findbar-status" value="&findbar.statusNotFound;"/>
+ </stack>
+ </hbox>
Wladimir Palant 2016/10/14 08:12:12 This block has been merely moved, no changes other
+
<tree id="filtersTree"
flex="1"
editable="true"
seltype="multiple"
enableColumnDrag="true"
hidecolumnpicker="true"
_removewarning="&filters.remove.warning;">
<treecols context="filters-view-menu1">
@@ -366,28 +378,16 @@
<treechildren id="filtersTreeChildren"
oncontextmenu="E('filterActionMenu').openPopupAtScreen(event.screenX, event.screenY, true);"
tooltip="filtersTooltip"
noGroupText="&noGroupSelected.text;"
noFiltersText="&noFiltersInGroup.text;"
ondragstart="FilterActions.startDrag(event);"
ondragend="FilterActions.endDrag(event);"/>
</tree>
-
- <hbox id="findbar" hidden="true" align="center" onkeypress="FilterSearch.keyPress(event);">
- <toolbarbutton id="findbar-closebutton" tooltiptext="&findbar.close;" oncommand="FilterSearch.close();"/>
- <textbox id="findbar-textbox" type="search" placeholder="&findbar.placeholder;" flex="1" oncommand="FilterSearch.search();"/>
- <spinbuttons id="findbar-findAgain" onup="FilterSearch.search(-1);" ondown="FilterSearch.search(1);"/>
- <button id="findbar-case-sensitive" type="checkbox" label="&findbar.caseSensitive;" oncommand="FilterSearch.search(0);"/>
- <stack>
- <label id="findbar-status-wrappedStart" class="findbar-status" value="&findbar.statusWrappedStart;"/>
- <label id="findbar-status-wrappedEnd" class="findbar-status" value="&findbar.statusWrappedEnd;"/>
- <label id="findbar-status-notFound" class="findbar-status" value="&findbar.statusNotFound;"/>
- </stack>
- </hbox>
</vbox>
</hbox>
<hbox id="buttons">
<button id="backupButton" type="menu"
label="&backupButton.label;"
_backupDialogTitle="&backup.label;" _restoreDialogTitle="&restore.own.label;"
_fileFilterComplete="&backup.complete.title;" _fileFilterCustom="&backup.custom.title;"
« no previous file with comments | « no previous file | chrome/content/ui/filters-filterview.js » ('j') | chrome/content/ui/filters-filterview.js » ('J')

Powered by Google App Engine
This is Rietveld