Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(179)

Issue 29357701: Issue 4548 - Split out Safari and add Edge release automation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by kzar
Modified:
3 years, 2 months ago
CC:
kvas
Visibility:
Public.

Description

Issue 4548 - Split out Safari and add Edge release automation

Patch Set 1 #

Patch Set 2 : Use correct appx extension for Edge build #

Total comments: 16

Patch Set 3 : Addressed feedback #

Total comments: 6

Patch Set 4 : Removed redundant keyFile parameters #

Patch Set 5 : Addressed nits #

Patch Set 6 : Add '-type' to release tag names for Safari+Edge #

Total comments: 5

Patch Set 7 : Avoid linting errors #

Total comments: 4

Patch Set 8 : Import getDefaultFileName and readMetadata from packager directly #

Total comments: 2

Patch Set 9 : Addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -27 lines) Patch
M build.py View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M packagerEdge.py View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M releaseAutomation.py View 1 2 3 4 5 6 7 8 3 chunks +26 lines, -19 lines 0 comments Download

Messages

Total messages: 26
kzar
Patch Set 1 These changes are completely untested, I have no idea how to test ...
3 years, 3 months ago (2016-10-19 11:44:13 UTC) #1
kzar
Patch Set 2 : Use correct appx extension for Edge build
3 years, 3 months ago (2016-10-19 11:55:55 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29357701/diff/29357705/releaseAutomation.py File releaseAutomation.py (right): https://codereview.adblockplus.org/29357701/diff/29357705/releaseAutomation.py#newcode111 releaseAutomation.py:111: packager.createBuild(baseDir, type=type, outFile=buildPathUnsigned, releaseBuild=True, keyFile=None) I suppose the absence ...
3 years, 2 months ago (2016-10-19 14:26:14 UTC) #3
kzar
https://codereview.adblockplus.org/29357701/diff/29357705/releaseAutomation.py File releaseAutomation.py (right): https://codereview.adblockplus.org/29357701/diff/29357705/releaseAutomation.py#newcode111 releaseAutomation.py:111: packager.createBuild(baseDir, type=type, outFile=buildPathUnsigned, releaseBuild=True, keyFile=None) On 2016/10/19 14:26:14, Sebastian ...
3 years, 2 months ago (2016-10-19 14:31:03 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29357701/diff/29357705/releaseAutomation.py File releaseAutomation.py (right): https://codereview.adblockplus.org/29357701/diff/29357705/releaseAutomation.py#newcode111 releaseAutomation.py:111: packager.createBuild(baseDir, type=type, outFile=buildPathUnsigned, releaseBuild=True, keyFile=None) On 2016/10/19 14:31:03, kzar ...
3 years, 2 months ago (2016-10-19 15:08:24 UTC) #5
Wladimir Palant
Please don't commit anything untested here, I really don't want to discover issues during release. ...
3 years, 2 months ago (2016-10-20 10:03:08 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29357701/diff/29357705/build.py File build.py (right): https://codereview.adblockplus.org/29357701/diff/29357705/build.py#newcode445 build.py:445: if (type == 'chrome' or type == 'safari') and ...
3 years, 2 months ago (2016-10-20 10:25:26 UTC) #7
kzar
Patch Set 3 : Addressed feedback I tested this somewhat by commenting out the `hg ...
3 years, 2 months ago (2016-10-20 12:09:36 UTC) #8
Wladimir Palant
On 2016/10/20 12:09:36, kzar wrote: > One question, do we need to adjust the tag ...
3 years, 2 months ago (2016-10-22 20:12:51 UTC) #9
Sebastian Noack
On 2016/10/22 20:12:51, Wladimir Palant wrote: > On 2016/10/20 12:09:36, kzar wrote: > > One ...
3 years, 2 months ago (2016-10-22 20:20:00 UTC) #10
Sebastian Noack
On 2016/10/22 20:20:00, Sebastian Noack wrote: > The plan was to keep Safari on the ...
3 years, 2 months ago (2016-10-22 20:31:14 UTC) #11
kzar
Patch Set 4 : Removed redundant keyFile parameters So the consensus is we stick with ...
3 years, 2 months ago (2016-10-25 07:50:52 UTC) #12
Wladimir Palant
https://codereview.adblockplus.org/29357701/diff/29358373/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29357701/diff/29358373/packagerEdge.py#newcode14 packagerEdge.py:14: from packager import (readMetadata, getDefaultFileName) On 2016/10/25 07:50:51, kzar ...
3 years, 2 months ago (2016-10-25 10:21:38 UTC) #13
kzar
Patch Set 5 : Addressed nits https://codereview.adblockplus.org/29357701/diff/29358373/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29357701/diff/29358373/packagerEdge.py#newcode14 packagerEdge.py:14: from packager import ...
3 years, 2 months ago (2016-10-25 10:36:37 UTC) #14
Sebastian Noack
On 2016/10/25 07:50:52, kzar wrote: > Patch Set 4 : Removed redundant keyFile parameters > ...
3 years, 2 months ago (2016-10-25 10:39:35 UTC) #15
kzar
Patch Set 6 : Add '-type' to release tag names for Safari+Edge
3 years, 2 months ago (2016-10-25 13:39:25 UTC) #16
Wladimir Palant
LGTM
3 years, 2 months ago (2016-10-25 13:44:10 UTC) #17
Vasily Kuznetsov
Please check that the tests still pass before pushing the changes. Right now it seems ...
3 years, 2 months ago (2016-10-25 16:16:26 UTC) #18
Sebastian Noack
https://codereview.adblockplus.org/29357701/diff/29359872/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29357701/diff/29359872/packagerEdge.py#newcode15 packagerEdge.py:15: from packager import readMetadata, getDefaultFileName On 2016/10/25 16:16:26, Vasily ...
3 years, 2 months ago (2016-10-26 09:33:14 UTC) #19
kzar
Patch Set 7 : Avoid linting errors https://codereview.adblockplus.org/29357701/diff/29359872/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29357701/diff/29359872/packagerEdge.py#newcode15 packagerEdge.py:15: from packager ...
3 years, 2 months ago (2016-10-26 15:19:13 UTC) #20
Sebastian Noack
https://codereview.adblockplus.org/29357701/diff/29359872/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29357701/diff/29359872/packagerEdge.py#newcode15 packagerEdge.py:15: from packager import readMetadata, getDefaultFileName It seems you ignored ...
3 years, 2 months ago (2016-10-27 10:57:32 UTC) #21
kzar
Patch Set 8 : Import getDefaultFileName and readMetadata from packager directly https://codereview.adblockplus.org/29357701/diff/29359872/packagerEdge.py File packagerEdge.py (right): ...
3 years, 2 months ago (2016-10-27 15:25:59 UTC) #22
Sebastian Noack
https://codereview.adblockplus.org/29357701/diff/29359952/releaseAutomation.py File releaseAutomation.py (right): https://codereview.adblockplus.org/29357701/diff/29359952/releaseAutomation.py#newcode85 releaseAutomation.py:85: tag_name += '-' + type On 2016/10/27 15:25:58, kzar ...
3 years, 2 months ago (2016-10-27 15:41:59 UTC) #23
kzar
Patch Set 9 : Addressed nits https://codereview.adblockplus.org/29357701/diff/29359952/releaseAutomation.py File releaseAutomation.py (right): https://codereview.adblockplus.org/29357701/diff/29359952/releaseAutomation.py#newcode85 releaseAutomation.py:85: tag_name += '-' ...
3 years, 2 months ago (2016-10-27 15:54:25 UTC) #24
Sebastian Noack
LGTM
3 years, 2 months ago (2016-10-27 15:57:35 UTC) #25
Wladimir Palant
3 years, 2 months ago (2016-10-28 08:38:05 UTC) #26
Message was sent while issue was closed.
Still LGTM here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5