Issue 4548 - Split out Safari and add Edge release automation

packagerEdge.py

Index: packagerEdge.py
diff --git a/packagerEdge.py b/packagerEdge.py
index c63064e8fbefaaec4482fbcfd2808d89e0a0668e..a3a33acb87b479831da074e6f5e749cd05793c0b 100644
--- a/packagerEdge.py
+++ b/packagerEdge.py
@@ -11,6 +11,7 @@ import zipfile
 
 import packager
 import packagerChrome
+from packager import (readMetadata, getDefaultFileName)

[Wladimir Palant, 2016/10/22 20:12:51]

Why did you add this? I don't see these functions being called directly, only as
packager.foo (packager module already being imported above).

[kzar, 2016/10/25 07:50:51]

This change was required for `./build.py -t edge release ...` to work. See these
lines approx 58 and 105 and in releaseAutomation.py:

metadata = packager.readMetadata(baseDir, type)

buildPath = os.path.join(downloadsRepo, packager.getDefaultFileName(metadata,
version, 'appx'))

[Wladimir Palant, 2016/10/25 10:21:37]

1) Please add a comment explaining that releaseAutomation expects these
functions even though this file doesn't need them.

2) Nit: The parentheses are unnecessary.

[kzar, 2016/10/25 10:36:37]

Done.

 
 # Files and directories expected inside of the .APPX archive.
 MANIFEST = 'AppxManifest.xml'
@@ -93,7 +94,7 @@ def create_appx_manifest(params, files, release_build=False):
     for size in ['44', '50', '150']:
         path = '{}/logo_{}.png'.format(ASSETS_DIR, size)
         if path not in files:
-            raise KeyError(path + 'is not found in files')
+            raise KeyError(path + ' is not found in files')
         params['logo_' + size] = path.replace('/', '\\')
 
     template = _get_template_for(MANIFEST)