 Issue 29357701:
  Issue 4548 - Split out Safari and add Edge release automation  (Closed)
    
  
    Issue 29357701:
  Issue 4548 - Split out Safari and add Edge release automation  (Closed) 
  | Index: releaseAutomation.py | 
| diff --git a/releaseAutomation.py b/releaseAutomation.py | 
| index 8625a3e802a3589f53a563a3dd720b7a658aa15b..b8335ad7774309f75abaa7f932b8799d28c65e06 100644 | 
| --- a/releaseAutomation.py | 
| +++ b/releaseAutomation.py | 
| @@ -43,9 +43,13 @@ def create_sourcearchive(repo, output): | 
| process.wait() | 
| -def run(baseDir, type, version, keyFiles, downloadsRepo): | 
| +def run(baseDir, type, version, keyFile, downloadsRepo): | 
| if type == 'gecko': | 
| import buildtools.packagerGecko as packager | 
| + elif type == 'safari': | 
| + import buildtools.packagerSafari as packager | 
| + elif type == 'edge': | 
| + import buildtools.packagerEdge as packager | 
| elif type == 'chrome': | 
| import buildtools.packagerChrome as packager | 
| @@ -81,27 +85,26 @@ def run(baseDir, type, version, keyFiles, downloadsRepo): | 
| # Create a release build | 
| downloads = [] | 
| if type == 'gecko': | 
| - keyFile = keyFiles[0] if keyFiles else None | 
| - metadata = packager.readMetadata(baseDir, type) | 
| buildPath = os.path.join(downloadsRepo, packager.getDefaultFileName(metadata, version, 'xpi')) | 
| - packager.createBuild(baseDir, type=type, outFile=buildPath, releaseBuild=True, keyFile=keyFile) | 
| + packager.createBuild(baseDir, type=type, outFile=buildPath, releaseBuild=True, keyFile=None) | 
| 
Wladimir Palant
2016/10/22 20:12:51
Please don't just remove the value - packagerGecko
 
kzar
2016/10/25 07:50:51
Done.
 | 
| downloads.append(buildPath) | 
| elif type == 'chrome': | 
| - # We actually have to create three different builds: signed and unsigned | 
| - # Chrome builds (the latter for Chrome Web Store), and a signed Safari build. | 
| - metadata = packager.readMetadata(baseDir, type) | 
| + # Create both signed and unsigned Chrome builds (the latter for Chrome Web Store). | 
| buildPath = os.path.join(downloadsRepo, packager.getDefaultFileName(metadata, version, 'crx')) | 
| - packager.createBuild(baseDir, type=type, outFile=buildPath, releaseBuild=True, keyFile=keyFiles[0]) | 
| + packager.createBuild(baseDir, type=type, outFile=buildPath, releaseBuild=True, keyFile=keyFile) | 
| downloads.append(buildPath) | 
| buildPathUnsigned = os.path.join(baseDir, packager.getDefaultFileName(metadata, version, 'zip')) | 
| packager.createBuild(baseDir, type=type, outFile=buildPathUnsigned, releaseBuild=True, keyFile=None) | 
| - | 
| - import buildtools.packagerSafari as packagerSafari | 
| - metadataSafari = packagerSafari.readMetadata(baseDir, 'safari') | 
| - buildPathSafari = os.path.join(downloadsRepo, packagerSafari.getDefaultFileName(metadataSafari, version, 'safariextz')) | 
| - packagerSafari.createBuild(baseDir, type='safari', outFile=buildPathSafari, releaseBuild=True, keyFile=keyFiles[1]) | 
| - downloads.append(buildPathSafari) | 
| + elif type == 'safari': | 
| + buildPath = os.path.join(downloadsRepo, packager.getDefaultFileName(metadata, version, 'safariextz')) | 
| + packager.createBuild(baseDir, type='safari', outFile=buildPath, releaseBuild=True, keyFile=keyFile) | 
| + downloads.append(buildPath) | 
| + elif type == 'edge': | 
| + # We only offer the Edge extension for use through the Windows Store | 
| + buildPath = os.path.join(downloadsRepo, packager.getDefaultFileName(metadata, version, 'appx')) | 
| + packager.createBuild(baseDir, type=type, outFile=buildPath, releaseBuild=True, keyFile=None) | 
| + downloads.append(buildPath) | 
| # Create source archive | 
| archivePath = os.path.splitext(buildPath)[0] + '-source.tgz' |