Issue 4548 - Split out Safari and add Edge release automation

packagerEdge.py

Index: packagerEdge.py
diff --git a/packagerEdge.py b/packagerEdge.py
index c63064e8fbefaaec4482fbcfd2808d89e0a0668e..1fcf6f3fd47ba0900d0429bfffe8d845947be964 100644
--- a/packagerEdge.py
+++ b/packagerEdge.py
@@ -11,6 +11,8 @@ import zipfile
 
 import packager
 import packagerChrome
+# These functions are unused here, but releaseAutomation.py expects them.
+from packager import readMetadata, getDefaultFileName

[Vasily Kuznetsov, 2016/10/25 16:16:26]

Please note that currently this causes `tox` to fail because `flake8` complains
about unused imports. This can be solved by adding `# flake8: noqa` comment to
the end of the line or (perhaps a bit more elegant) by adding those symbols (and
maybe everything else that is expected to be here) to `__all__`.

[Sebastian Noack, 2016/10/26 09:33:14]

I'd like to avoid #noqa as much as possible. But I'm not a fan of __all__
either, since "from import *" is generally discouraged.

Any reason the releaseAutomation module isn't importing those functions directly
from the packager module? It seems it isn't overridden by any platform-specific
packager anyway.

[kzar, 2016/10/26 15:19:13]

Ah sorry, I didn't realise the repository had tests! Since it took me a minute
to figure out how to run them I've opened a review to add a README for the next
person: https://codereview.adblockplus.org/29359949/

Also I found the tests fail for me even on master, this seems to be since my
system expects a different content type for OTF files. I've opened an issue for
that: https://issues.adblockplus.org/ticket/4575#ticket

Done.

[Sebastian Noack, 2016/10/27 10:57:32]

It seems you ignored my comment from above:

On 2016/10/26 09:33:14, Sebastian Noack wrote:

[kzar, 2016/10/27 15:25:58]

Whoops, so I did. Done.

 
 # Files and directories expected inside of the .APPX archive.
 MANIFEST = 'AppxManifest.xml'
@@ -93,7 +95,7 @@ def create_appx_manifest(params, files, release_build=False):
     for size in ['44', '50', '150']:
         path = '{}/logo_{}.png'.format(ASSETS_DIR, size)
         if path not in files:
-            raise KeyError(path + 'is not found in files')
+            raise KeyError(path + ' is not found in files')
         params['logo_' + size] = path.replace('/', '\\')
 
     template = _get_template_for(MANIFEST)