Side by Side Diff: sitescripts/extensions/utils.py
Issue 29358368:
Issue 4540 - Add Platform Specific Branch Support to createNightlies.py (Closed)
Patch Set: addressing feedback from wladimir
Created Oct. 25, 2016, 5:16 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« sitescripts/extensions/bin/createNightlies.py ('K')
|
« sitescripts/extensions/test/test_updateManifests.py ('k')
|
no next file »
|
no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 # This file is part of the Adblock Plus web scripts, | 1 # This file is part of the Adblock Plus web scripts, |
| 2 # Copyright (C) 2006-2016 Eyeo GmbH | 2 # Copyright (C) 2006-2016 Eyeo GmbH |
| 3 # | 3 # |
| 4 # Adblock Plus is free software: you can redistribute it and/or modify | 4 # Adblock Plus is free software: you can redistribute it and/or modify |
| 5 # it under the terms of the GNU General Public License version 3 as | 5 # it under the terms of the GNU General Public License version 3 as |
| 6 # published by the Free Software Foundation. | 6 # published by the Free Software Foundation. |
| 7 # | 7 # |
| 8 # Adblock Plus is distributed in the hope that it will be useful, | 8 # Adblock Plus is distributed in the hope that it will be useful, |
| 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of | 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| (...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 126 """ | 126 """ |
| 127 Creates a property corresponding with a key in the nightly config file | 127 Creates a property corresponding with a key in the nightly config file |
| 128 """ | 128 """ |
| 129 return property(lambda self: self.nightlyConfig.get(self.repositoryName, key), | 129 return property(lambda self: self.nightlyConfig.get(self.repositoryName, key), |
| 130 lambda self, value: self.nightlyConfig.set(self.reposito ryName, key, value)) | 130 lambda self, value: self.nightlyConfig.set(self.reposito ryName, key, value)) |
| 131 | 131 |
| 132 config = None | 132 config = None |
| 133 nightlyConfig = None | 133 nightlyConfig = None |
| 134 repositoryName = None | 134 repositoryName = None |
| 135 repository = None | 135 repository = None |
| 136 bookmark = _defineProperty('bookmark', default='master') | |
|
Wladimir Palant
2016/10/26 15:34:03
It seems that we want this property (and the corre
Jon Sonesen
2016/10/26 17:44:05
Done.
| |
| 136 | 137 |
| 137 spiderMonkeyBinary = _defineProperty('spiderMonkeyBinary', default='') | 138 spiderMonkeyBinary = _defineProperty('spiderMonkeyBinary', default='') |
| 138 nightliesDirectory = _defineProperty('nightliesDirectory') | 139 nightliesDirectory = _defineProperty('nightliesDirectory') |
| 139 nightliesURL = _defineProperty('nightliesURL') | 140 nightliesURL = _defineProperty('nightliesURL') |
| 140 downloadsRepo = _defineProperty('downloadsRepo') | 141 downloadsRepo = _defineProperty('downloadsRepo') |
| 141 downloadsURL = _defineProperty('downloadsURL') | 142 downloadsURL = _defineProperty('downloadsURL') |
| 142 docsDirectory = _defineProperty('docsDirectory') | 143 docsDirectory = _defineProperty('docsDirectory') |
| 143 signtool = _defineProperty('signtool') | 144 signtool = _defineProperty('signtool') |
| 144 certname = _defineProperty('signtool_certname') | 145 certname = _defineProperty('signtool_certname') |
| 145 dbdir = _defineProperty('signtool_dbdir') | 146 dbdir = _defineProperty('signtool_dbdir') |
| (...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 374 if not extensions: | 375 if not extensions: |
| 375 return | 376 return |
| 376 | 377 |
| 377 updates = {} | 378 updates = {} |
| 378 for extension in extensions: | 379 for extension in extensions: |
| 379 updates[extension['basename']] = { | 380 updates[extension['basename']] = { |
| 380 'url': extension['updateURL'], | 381 'url': extension['updateURL'], |
| 381 'version': extension['version'] | 382 'version': extension['version'] |
| 382 } | 383 } |
| 383 writeLibabpUpdateManifest(path, updates) | 384 writeLibabpUpdateManifest(path, updates) |
| OLD | NEW |
« sitescripts/extensions/bin/createNightlies.py ('K')
|
« sitescripts/extensions/test/test_updateManifests.py ('k')
|
no next file »
|
no next file with comments »
