Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: sitescripts/extensions/test/test_createNightlies.py

Issue 29358368: Issue 4540 - Add Platform Specific Branch Support to createNightlies.py (Closed)
Left Patch Set: adds fixture to generate place holder nightlies file, removes nightlies file from repo Created Oct. 25, 2016, 10:29 a.m.
Right Patch Set: Created Oct. 26, 2016, 5:53 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « sitescripts/extensions/test/conftest.py ('k') | sitescripts/extensions/test/test_updateManifests.py » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # This file is part of the Adblock Plus web scripts, 1 # This file is part of the Adblock Plus web scripts,
2 # Copyright (C) 2006-2016 Eyeo GmbH 2 # Copyright (C) 2006-2016 Eyeo GmbH
3 # 3 #
4 # Adblock Plus is free software: you can redistribute it and/or modify 4 # Adblock Plus is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License version 3 as 5 # it under the terms of the GNU General Public License version 3 as
6 # published by the Free Software Foundation. 6 # published by the Free Software Foundation.
7 # 7 #
8 # Adblock Plus is distributed in the hope that it will be useful, 8 # Adblock Plus is distributed in the hope that it will be useful,
9 # but WITHOUT ANY WARRANTY; without even the implied warranty of 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # GNU General Public License for more details. 11 # GNU General Public License for more details.
12 # 12 #
13 # You should have received a copy of the GNU General Public License 13 # You should have received a copy of the GNU General Public License
14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
15 15
16 """Tests for create nightlies script.""" 16 """Tests for create nightlies script."""
17 import pytest 17 import pytest
18 18
19 from sitescripts.extensions.bin import createNightlies 19 from sitescripts.extensions.bin import createNightlies
20 from sitescripts.utils import get_config 20 from sitescripts.utils import get_config
21 21
22 22
23 @pytest.fixture() 23 @pytest.fixture()
24 def config(hg_dir): 24 def config(hg_dir):
25 config = get_config() 25 config = get_config()
26 config.type = 'safari' 26 config.type = 'safari'
27 config.repository = str(hg_dir.join('adblockplusnightly')) 27 config.repository = str(hg_dir.join('adblockplusnightly'))
28 config.revision = 'safari'
28 return config 29 return config
29 30
30 31
31 @pytest.fixture() 32 @pytest.fixture()
32 def nightlybuild(config): 33 def nightlybuild(config):
33 return createNightlies.NightlyBuild(config) 34 return createNightlies.NightlyBuild(config)
34 35
35 36
36 def test_nightly_object_bookmark(nightlybuild): 37 def test_nightly_object_bookmark(nightlybuild):
Vasily Kuznetsov 2016/10/25 16:04:33 It seems that this test only checks how the nightl
Jon Sonesen 2016/10/25 16:29:13 1. Right now if the bookmark is absent the script
Vasily Kuznetsov 2016/10/25 16:46:46 1. I meant "if the abpxxx_bookmark configuration o
37 assert nightlybuild.bookmark == 'safari' 38 assert nightlybuild.config.revision == 'safari'
LEFTRIGHT

Powered by Google App Engine
This is Rietveld