Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/io.js

Issue 29360036: Issue 4576 - Fixed deep recursion when reading patterns.ini with please_kill_startup_performance se… (Closed) Base URL: https://hg.adblockplus.org/adblockplus
Patch Set: Created Oct. 28, 2016, 8:47 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/io.js
===================================================================
--- a/lib/io.js
+++ b/lib/io.js
@@ -89,17 +89,21 @@ let IO = exports.IO =
{
let oldBuffer = buffer;
buffer = data.substr(index + 1);
data = data.substr(0, index + 1);
let lines = data.split(/[\r\n]+/);
lines.pop();
lines[0] = oldBuffer + lines[0];
for (let i = 0; i < lines.length; i++)
- yield listener.process(lines[i]);
+ {
+ let promise = listener.process(lines[i]);
+ if (promise)
+ yield listener.process(lines[i]);
+ }
}
finally
{
processing = false;
data = buffer;
buffer = "";
yield* onProgress(data);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld