Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29361133: Issue 4544 - Consider platformHTMLBindings.xml when detecting available keyboard shortcuts (Closed)

Created:
Oct. 31, 2016, 10:02 a.m. by Wladimir Palant
Modified:
Oct. 31, 2016, 2:08 p.m.
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/buildtools
Visibility:
Public.

Description

This also removes the now pointless special handling of XMLHttpRequest - this global should always be available in modules.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M lib/keySelector.js View 2 chunks +16 lines, -1 line 0 comments Download
M packagerGecko.py View 1 chunk +0 lines, -3 lines 0 comments Download
M templates/bootstrap.js.tmpl View 2 chunks +3 lines, -9 lines 2 comments Download

Messages

Total messages: 3
Wladimir Palant
Oct. 31, 2016, 10:02 a.m. (2016-10-31 10:02:50 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29361133/diff/29361134/templates/bootstrap.js.tmpl File templates/bootstrap.js.tmpl (right): https://codereview.adblockplus.org/29361133/diff/29361134/templates/bootstrap.js.tmpl#newcode13 templates/bootstrap.js.tmpl:13: "TextDecoder", "TextEncoder", "XMLHttpRequest"]); For reference: originally there was no ...
Oct. 31, 2016, 10:06 a.m. (2016-10-31 10:06:43 UTC) #2
kzar
Oct. 31, 2016, 1:03 p.m. (2016-10-31 13:03:24 UTC) #3
Of course I'm not too familiar with any of this code, but LGTM.

Powered by Google App Engine
This is Rietveld