libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domain_item.xml - Issue 29361445: Issue 4399 - Add WebView inheritor with ad blocking

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domain_item.xml

Issue 29361445: Issue 4399 - Add WebView inheritor with ad blocking (Closed)

Patch Set: Created Nov. 1, 2016, 12:14 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

« libadblockplus-android-settings/project.properties ('K') | « libadblockplus-android-settings/res/drawable-xxxhdpi/ic_remove_circle_outline_black_24dp.png ('k') | libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domains_settings.xml » ('j') | libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domains_settings.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <LinearLayout

	3 xmlns:android="http://schemas.android.com/apk/res/android"

	4 xmlns:tools="http://schemas.android.com/tools"

	5 android:layout_width="match_parent"

	6 android:layout_height="match_parent"

	7 android:gravity="center_vertical"

	8 android:orientation="horizontal"

	9 android:paddingTop="@dimen/fragment_adblock_wl_item_padding"

	10 android:paddingBottom="@dimen/fragment_adblock_wl_item_padding">

	11

	12 <!-- Domain -->

	13 <TextView

	14 android:id="@+id/fragment_adblock_wl_item_title"

	15 android:layout_width="1px"
	diegocarloslima 2016/11/08 16:30:39 It's usually recommended to use 0dp here when layo It's usually recommended to use 0dp here when layout_weight is also present. Any particular reason for using 1px? anton 2016/11/09 12:30:29 The reason was Android Studio was reporting that t Show quoted text On 2016/11/08 16:30:39, diegocarloslima wrote: > It's usually recommended to use 0dp here when layout_weight is also present. Any > particular reason for using 1px? The reason was Android Studio was reporting that the element will be invisible even if it has weight=1 (why?). I used to use 0 too so i agree i should use 0 anyway.
	16 android:layout_weight="1"

	17 android:layout_height="wrap_content"

	18 android:paddingLeft="0dp"

	19 android:textAppearance="?android:attr/textAppearanceMedium"

	20 tools:text="http://www.google.com"/>

	21

	22 <!-- Remove button -->

	23 <ImageView

	24 android:id="@+id/fragment_adblock_wl_item_remove"

	25 android:layout_width="wrap_content"

	26 android:layout_height="wrap_content"

	27 android:src="@drawable/fragment_adblock_whitelisted_domains_remove"

	28 android:paddingLeft="@dimen/fragment_adblock_wl_padding" />

	29

	30 </LinearLayout>

OLD	NEW