Side by Side Diff: libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domains_settings.xml
Issue 29361445:
Issue 4399 - Add WebView inheritor with ad blocking (Closed)
Patch Set:
Created Nov. 1, 2016, 12:14 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domain_item.xml ('K')
|
« libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domain_item.xml ('k')
|
libadblockplus-android-settings/res/values/adblock_settings_dimen_internal.xml » ('j')
|
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/Adblock.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <LinearLayout | |
| 2 xmlns:android="http://schemas.android.com/apk/res/android" | |
| 3 xmlns:tools="http://schemas.android.com/tools" | |
| 4 android:layout_width="match_parent" | |
| 5 android:layout_height="match_parent" | |
| 6 android:orientation="vertical" | |
| 7 android:padding="@dimen/fragment_adblock_wl_padding" | |
| 8 tools:context="org.adblockplus.libadblockplus.android.settings.AdblockWhitel istedDomainsSettingsFragment"> | |
| 9 | |
| 10 <LinearLayout | |
| 11 android:layout_width="match_parent" | |
| 12 android:layout_height="wrap_content" | |
| 13 android:orientation="horizontal"> | |
| 14 | |
| 15 <!-- Add domain input --> | |
| 16 <EditText | |
| 17 android:id="@+id/fragment_adblock_wl_add_label" | |
| 18 android:layout_width="1px" | |
| 19 android:layout_weight="1" | |
|
diegocarloslima
2016/11/08 16:30:39
It's usually recommended to use 0dp here when layo
anton
2016/11/09 12:30:29
Acknowledged.
| |
| 20 android:layout_height="wrap_content" | |
| 21 android:lines="1" | |
| 22 android:hint="@string/fragment_adblock_settings_add_domain" | |
| 23 android:inputType="textUri" | |
| 24 android:textAppearance="?android:attr/textAppearanceMedium" /> | |
| 25 | |
| 26 <!-- Add button --> | |
| 27 <ImageView | |
| 28 android:id="@+id/fragment_adblock_wl_add_button" | |
| 29 android:layout_width="wrap_content" | |
| 30 android:layout_height="wrap_content" | |
| 31 android:layout_gravity="center_vertical" | |
| 32 android:src="@drawable/fragment_adblock_whitelisted_domains_add" | |
| 33 android:paddingLeft="@dimen/fragment_adblock_wl_item_padding" /> | |
| 34 | |
| 35 </LinearLayout> | |
| 36 | |
| 37 <!-- Whitelisted domain label --> | |
| 38 <TextView | |
| 39 android:layout_width="match_parent" | |
| 40 android:layout_height="wrap_content" | |
| 41 android:text="@string/fragment_adblock_settings_wl_domains" | |
| 42 android:paddingTop="@dimen/fragment_adblock_wl_padding" | |
| 43 android:paddingBottom="@dimen/fragment_adblock_wl_padding" | |
| 44 android:textAppearance="?android:attr/textAppearanceMedium"/> | |
| 45 | |
| 46 <!-- ListView --> | |
| 47 <ListView | |
| 48 android:id="@+id/fragment_adblock_wl_listview" | |
| 49 android:layout_width="match_parent" | |
| 50 android:layout_height="match_parent"/> | |
| 51 | |
| 52 </LinearLayout> | |
| OLD | NEW |
« libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domain_item.xml ('K')
|
« libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domain_item.xml ('k')
|
libadblockplus-android-settings/res/values/adblock_settings_dimen_internal.xml » ('j')
|
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/Adblock.java » ('J')
