Issue 4399 - Add WebView inheritor with ad blocking

libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2016 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package org.adblockplus.libadblockplus.android.settings;
+
+import org.adblockplus.libadblockplus.android.Subscription;
+
+import java.io.Serializable;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Set;

[diegocarloslima, 2016/11/08 16:30:42]

Arrays, HashSet, LinkedList and Set imports doesn't seem to be used

[anton, 2016/11/09 12:30:33]

Acknowledged.

+
+/**
+ * Adblock settings
+ */
+public class AdblockSettings implements Serializable
+{
+  private transient boolean adblockEnabled;
+
+  public boolean isAdblockEnabled()
+  {
+    return adblockEnabled;
+  }
+
+  public void setAdblockEnabled(boolean adblockEnabled)
+  {
+    this.adblockEnabled = adblockEnabled;
+  }
+
+  private transient Boolean acceptableAdsEnabled;

[diegocarloslima, 2016/11/08 16:30:43]

I feel like having member variable declarations mixed with methods is less
readable and confusing

[anton, 2016/11/09 12:30:32]

I feel comfortable with both styles because of advanced IDE and i will do what
is more preferred to company style (did not find it in
http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-13605...)

+
+  public boolean isAcceptableAdsEnabled()
+  {
+    return acceptableAdsEnabled;
+  }
+
+  public void setAcceptableAdsEnabled(boolean acceptableAdsEnabled)
+  {
+    this.acceptableAdsEnabled = acceptableAdsEnabled;
+  }
+
+  private List<Subscription> subscriptions;

[diegocarloslima, 2016/11/08 16:30:42]

I feel like having member variable declarations mixed with methods is less
readable and confusing

[anton, 2016/11/09 12:30:33]

I feel comfortable with both styles because of advanced IDE and i will do what
is more preferred to company style (did not find it in
http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-13605...)

+
+  public List<Subscription> getSubscriptions()
+  {
+    return subscriptions;
+  }
+
+  public void setSubscriptions(List<Subscription> subscriptions)
+  {
+    this.subscriptions = subscriptions;
+  }
+
+  private List<String> whitelistedDomains;

[diegocarloslima, 2016/11/08 16:30:42]

I feel like having member variable declarations mixed with methods is less
readable and confusing

[anton, 2016/11/09 12:30:32]

I feel comfortable with both styles because of advanced IDE and i will do what
is more preferred to company style (did not find it in
http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-13605...)

+
+  public List<String> getWhitelistedDomains()
+  {
+    return whitelistedDomains;
+  }
+
+  public void setWhitelistedDomains(List<String> whitelistedDomains)
+  {
+    this.whitelistedDomains = whitelistedDomains;
+  }
+
+  @Override
+  public String toString()
+  {
+    return "AdblockSettings{" +
+      "adblockEnabled=" + adblockEnabled +
+      ", acceptableAdsEnabled=" + acceptableAdsEnabled +
+      ", subscriptions:" + (subscriptions != null ? subscriptions.size() : 0) +
+      ", whitelistedDomains:" + (whitelistedDomains != null ? whitelistedDomains.size() : 0) +
+      '}';
+  }
+}