Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: libadblockplus-android-webviewapp/AndroidManifest.xml

Issue 29361445: Issue 4399 - Add WebView inheritor with ad blocking (Closed)
Patch Set: Created Nov. 1, 2016, 12:14 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 <?xml version="1.0" encoding="utf-8"?>
2 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
3 package="org.adblockplus.libadblockplus.android.webviewapp"
4 android:versionCode="1"
5 android:versionName="1.0">
6
7 <uses-sdk
8 android:minSdkVersion="17"
9 android:targetSdkVersion="21"/>
diegocarloslima 2016/11/08 16:30:56 Couldn't we target at least API 22?
10
11 <uses-permission android:name="android.permission.INTERNET"/>
12
13 <android:uses-permission android:name="android.permission.WRITE_EXTERNAL_STO RAGE"/>
14 <android:uses-permission android:name="android.permission.READ_PHONE_STATE"/ >
15 <android:uses-permission android:name="android.permission.READ_EXTERNAL_STOR AGE"/>
diegocarloslima 2016/11/08 16:30:56 These 'uses-permission' elements with android name
anton 2016/11/09 12:30:42 Agee, they were added by IDE and to be honest i do
16
17 <application
18 android:icon="@drawable/icon"
19 android:name=".Application"
20 android:label="@string/app_name">
21
22 <!-- main -->
23 <activity
24 android:name=".MainActivity"
25 android:label="@string/app_name"
26 android:launchMode="singleTop">
27 <intent-filter>
28 <action android:name="android.intent.action.MAIN"/>
29
30 <category android:name="android.intent.category.LAUNCHER"/>
31 </intent-filter>
32 </activity>
33
34 <!-- settings -->
35 <activity
36 android:name=".SettingsActivity"
37 android:label="@string/settings_name"
38 android:theme="@android:style/Theme.DeviceDefault.Light"/>
39 </application>
40
41 </manifest>
OLDNEW

Powered by Google App Engine
This is Rietveld