Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: libadblockplus-android-webviewapp/res/layout/activity_main.xml

Issue 29361445: Issue 4399 - Add WebView inheritor with ad blocking (Closed)
Patch Set: Created Nov. 1, 2016, 12:14 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 <?xml version="1.0" encoding="utf-8"?>
2
3 <LinearLayout
4 xmlns:android="http://schemas.android.com/apk/res/android"
5 android:layout_width="match_parent"
6 android:layout_height="match_parent"
7 android:orientation="vertical">
8
9 <EditText
10 android:id="@+id/main_url"
11 android:layout_width="match_parent"
12 android:layout_height="wrap_content"
13 android:text="http://www.google.com"
diegocarloslima 2016/11/08 16:30:57 I'm personally not a big fan of hardcoding strings
anton 2016/11/09 12:30:43 It just for testing purposing, agree to remove it.
14 android:inputType="textUri"
15 android:singleLine="true"/>
diegocarloslima 2016/11/08 16:30:58 singleLine is deprecated, it's better to use maxLi
anton 2016/11/09 12:30:42 I've seen IDE suggestion to replace it but it prov
16
17 <LinearLayout
18 android:layout_width="match_parent"
19 android:layout_height="wrap_content"
20 android:orientation="horizontal">
21
22 <Button
23 android:id="@+id/main_ok"
24 android:layout_width="wrap_content"
25 android:layout_height="wrap_content"
26 android:text="@string/main_ok"/>
27
28 <Button
29 android:id="@+id/main_back"
30 android:layout_width="50dp"
31 android:layout_height="wrap_content"
32 android:text="@string/main_prev"/>
33
34 <Button
35 android:id="@+id/main_forward"
36 android:layout_width="50dp"
37 android:layout_height="wrap_content"
38 android:text="@string/main_next"/>
39
40 <Button
41 android:id="@+id/main_settings"
42 android:layout_width="wrap_content"
43 android:layout_height="wrap_content"
44 android:text="@string/main_settings"/>
45
46 </LinearLayout>
47
48 <ProgressBar
49 android:id="@+id/main_progress"
50 android:layout_width="match_parent"
51 android:layout_height="wrap_content"
52 style="?android:attr/progressBarStyleHorizontal"
53 android:indeterminate="false"
54 android:indeterminateOnly="false"
55 android:max="100"/>
56
57 <org.adblockplus.libadblockplus.android.webview.AdblockWebView
58 android:id="@+id/main_webview"
59 android:layout_width="match_parent"
60 android:layout_height="match_parent"/>
61
62 </LinearLayout>
OLDNEW

Powered by Google App Engine
This is Rietveld