Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: libadblockplus-android-settings/res/values/adblock_settings_dimen_internal.xml
Issue
29361445
:
Issue 4399 - Add WebView inheritor with ad blocking (Closed)
Patch Set: fixed 2 more members in AdblockEngine
Created Dec. 16, 2016, 8:31 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: detecting if it's XmlHttpRequest + changes from https://codereview.adblockplus.org/29361556/
Patch Set 3: fixes according to Diego's suggestions
Patch Set 4: fixed 'in _the_ .. directory' in README
Patch Set 5: added retaining in asynchronous mode
Patch Set 6: code clean-up (Diego's suggestions)
Patch Set 7: applied codestyle: members first, methods then
Patch Set 8: fixed 2 more members in AdblockEngine
Patch Set 9: removed client <21, fixed typos, moved Adblock level out of .android.settings
Patch Set 10: renamings, updated README
Right:
Patch Set 1: None
Patch Set 2: detecting if it's XmlHttpRequest + changes from https://codereview.adblockplus.org/29361556/
Patch Set 3: fixes according to Diego's suggestions
Patch Set 4: fixed 'in _the_ .. directory' in README
Patch Set 5: added retaining in asynchronous mode
Patch Set 6: code clean-up (Diego's suggestions)
Patch Set 7: applied codestyle: members first, methods then
Patch Set 8: fixed 2 more members in AdblockEngine
Patch Set 9: removed client <21, fixed typos, moved Adblock level out of .android.settings
Patch Set 10: renamings, updated README
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.gitignore
.hgignore
README.md
build.gradle
gradle/wrapper/gradle-wrapper.properties
libadblockplus-android-settings/AndroidManifest.xml
libadblockplus-android-settings/build.gradle
libadblockplus-android-settings/build.xml
libadblockplus-android-settings/pom.xml
libadblockplus-android-settings/project.properties
libadblockplus-android-settings/res/drawable-hdpi/fragment_adblock_whitelisted_domains_add.png
libadblockplus-android-settings/res/drawable-hdpi/fragment_adblock_whitelisted_domains_remove.png
libadblockplus-android-settings/res/drawable-mdpi/fragment_adblock_whitelisted_domains_add.png
libadblockplus-android-settings/res/drawable-mdpi/fragment_adblock_whitelisted_domains_remove.png
libadblockplus-android-settings/res/drawable-xhdpi/fragment_adblock_whitelisted_domains_add.png
libadblockplus-android-settings/res/drawable-xhdpi/fragment_adblock_whitelisted_domains_remove.png
libadblockplus-android-settings/res/drawable-xxhdpi/fragment_adblock_whitelisted_domains_add.png
libadblockplus-android-settings/res/drawable-xxhdpi/fragment_adblock_whitelisted_domains_remove.png
libadblockplus-android-settings/res/drawable-xxxhdpi/ic_add_circle_outline_black_24dp.png
libadblockplus-android-settings/res/drawable-xxxhdpi/ic_remove_circle_outline_black_24dp.png
libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domain_item.xml
libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domains_settings.xml
libadblockplus-android-settings/res/values/adblock_settings_dimen_internal.xml
libadblockplus-android-settings/res/values/adblock_settings_strings.xml
libadblockplus-android-settings/res/values/adblock_settings_strings_internal.xml
libadblockplus-android-settings/res/xml/preference_adblock_general.xml
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/Adblock.java
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockGeneralSettingsFragment.java
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettingsFragment.java
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettingsSharedPrefsStorage.java
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettingsStorage.java
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockWhitelistedDomainsSettingsFragment.java
libadblockplus-android-tests/AndroidManifest.xml
libadblockplus-android-tests/build.gradle
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UtilsTest.java
libadblockplus-android-webview/AndroidManifest.xml
libadblockplus-android-webview/assets/css.js
libadblockplus-android-webview/assets/empty.js
libadblockplus-android-webview/assets/hide.js
libadblockplus-android-webview/assets/inject.js
libadblockplus-android-webview/build.gradle
libadblockplus-android-webview/build.xml
libadblockplus-android-webview/pom.xml
libadblockplus-android-webview/project.properties
libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java
libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/IoThreadClientInvocationHandler.java
libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/ReflectionUtils.java
libadblockplus-android-webviewapp/AndroidManifest.xml
libadblockplus-android-webviewapp/build.gradle
libadblockplus-android-webviewapp/build.xml
libadblockplus-android-webviewapp/pom.xml
libadblockplus-android-webviewapp/project.properties
libadblockplus-android-webviewapp/res/drawable/icon.png
libadblockplus-android-webviewapp/res/layout/activity_main.xml
libadblockplus-android-webviewapp/res/values/strings.xml
libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java
libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/MainActivity.java
libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/SettingsActivity.java
libadblockplus-android/AndroidManifest.xml
libadblockplus-android/build.gradle
libadblockplus-android/jni/JniFilterEngine.cpp
libadblockplus-android/jni/Utils.h
libadblockplus-android/jni/Utils.cpp
libadblockplus-android/pom.xml
libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java
libadblockplus-android/src/org/adblockplus/android/Utils.java
libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java
libadblockplus-android/src/org/adblockplus/libadblockplus/JniExceptionHandler.java
libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java
libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidLogSystem.java
libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequest.java
libadblockplus-android/src/org/adblockplus/libadblockplus/android/Subscription.java
libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java
pom.xml
settings.gradle
View unified diff
|
Download patch
« libadblockplus-android-settings/build.xml
('K') |
« libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domains_settings.xml
('k') |
libadblockplus-android-settings/res/values/adblock_settings_strings.xml »
('j') |
libadblockplus-android-webview/assets/hide.js »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<?xml version="1.0" encoding="utf-8"?>
2
<resources>
3
4
<dimen name="fragment_adblock_wl_padding">16dp</dimen>
5
<dimen name="fragment_adblock_wl_item_padding">8dp</dimen>
6
7
</resources>
OLD
NEW
« libadblockplus-android-settings/build.xml
('K') |
« libadblockplus-android-settings/res/layout/fragment_adblock_whitelisted_domains_settings.xml
('k') |
libadblockplus-android-settings/res/values/adblock_settings_strings.xml »
('j') |
libadblockplus-android-webview/assets/hide.js »
('J')
Edit Message
Issue 29361445: Issue 4399 - Add WebView inheritor with ad blocking (Closed)
Created Nov. 1, 2016, 12:14 p.m. by anton
Modified Dec. 20, 2016, 12:21 p.m.
Reviewers: diegocarloslima, Felix Dahlke
Base URL:
Comments: 146
This is Rietveld