Issue 3594 - remove circular references JsEngine-JsValue-JsEngine

test/Prefs.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 56 matching lines @@
   protected:
     TestFileSystem* fileSystem;
     AdblockPlus::FileSystemPtr fileSystemPtr;
     AdblockPlus::JsEnginePtr jsEngine;
     FilterEnginePtr filterEngine;
 
     void SetUp()
     {
       fileSystem = new TestFileSystem();
       fileSystemPtr.reset(fileSystem);
+      jsEngine = CreateJsEngine();
 
       Reset();
     }
 
     void Reset(const AdblockPlus::FilterEngine::Prefs& preconfiguredPrefs =
                AdblockPlus::FilterEngine::Prefs())
     {
-      jsEngine = CreateJsEngine();
       jsEngine->SetLogSystem(AdblockPlus::LogSystemPtr(new LazyLogSystem));
       jsEngine->SetFileSystem(fileSystemPtr);
       jsEngine->SetWebRequest(AdblockPlus::WebRequestPtr(new LazyWebRequest));
 
       filterEngine.reset(
         new AdblockPlus::FilterEngine(jsEngine, preconfiguredPrefs));
     }
   };
 }
 
@@ skipping 100 matching lines @@
 
   AdblockPlus::Sleep(100);
 
   ASSERT_FALSE(fileSystem->prefsContents.empty());
 
   Reset(preconfiguredPrefs);
 
   ASSERT_TRUE(filterEngine->GetPref("suppress_first_run_page")->IsBool());
   ASSERT_FALSE(filterEngine->GetPref("suppress_first_run_page")->AsBool());
 }