Issue 3594 - remove circular references JsEngine-JsValue-JsEngine

test/JsEngine.cpp

Index: test/JsEngine.cpp
diff --git a/test/JsEngine.cpp b/test/JsEngine.cpp
index 3684620c57301f61423d903ec7dfc8e5fc680422..d2e1e37f88f9b26bfbc361b13a67f3867412fa8a 100644
--- a/test/JsEngine.cpp
+++ b/test/JsEngine.cpp
@@ -134,3 +134,23 @@ TEST(NewJsEngineTest, GlobalPropertyTest)
   ASSERT_EQ(foo->AsString(), "bar");
 }
 
+TEST(NewJsEngineTest, MemoryLeak_NoCircularReferences)
+{
+  std::weak_ptr<AdblockPlus::JsEngine> weakJsEngine;
+  {
+    weakJsEngine = AdblockPlus::JsEngine::New();
+  }
+  EXPECT_FALSE(weakJsEngine.lock());
+}
+
+TEST(NewJsEngineTest, MemoryLeak_NoLeak)

[Oleksandr, 2016/11/25 10:38:04]

This seems like a one brutal test :). Does this actually raise an exception with
circular dependencies?

[sergei, 2016/11/25 12:04:46]

Yes, it perfectly does crash, i = 939 or 940. It means that only ~60 instances
are instantiated and 2GB/60 ~ 33.3MB what conforms with the expectations. It
fails trying to commit (VirtualAlloc) 32MB, in platform-win32.cc, however the
actual crash happens later in v8, by V8::FatalProcessOutOfMemory("heap setup");

+{
+  // v8::Isolate by default requires 32MB, so if there is a memory leak than
+  // we will run out of memory on 32 bit platform because it will allocate
+  // 32000 MB which is less than 2GB where it reaches out of memory.
+  int i = 1000;
+  while (i-->0)
+  {
+    AdblockPlus::JsEngine::New();
+  }
+}