test/BaseJsTest.cpp - Issue 29361562: Issue 3594 - remove circular references JsEngine-JsValue-JsEngine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: test/BaseJsTest.cpp

Issue 29361562: Issue 3594 - remove circular references JsEngine-JsValue-JsEngine (Closed)

Patch Set: address comments Created Nov. 25, 2016, 12:02 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: test/BaseJsTest.cpp

diff --git a/test/BaseJsTest.cpp b/test/BaseJsTest.cpp

index 896d87b27fe1901aa647f056524dd1bc84917202..27f9be72ccbeac32b9c55a3cf360a529debd808e 100644

--- a/test/BaseJsTest.cpp

+++ b/test/BaseJsTest.cpp

@@ -19,6 +19,5 @@

AdblockPlus::JsEnginePtr CreateJsEngine(const AdblockPlus::AppInfo& appInfo)

{

- static AdblockPlus::ScopedV8IsolatePtr isolate = std::make_shared<AdblockPlus::ScopedV8Isolate>();

- return AdblockPlus::JsEngine::New(appInfo, isolate);

+ return AdblockPlus::JsEngine::New(appInfo);

}