scss/_variables.scss - Issue 29361647: Issue 4607 - Default content styles

Side by Side Diff: scss/_variables.scss

Issue 29361647: Issue 4607 - Default content styles (Closed)

Patch Set: Removed responsive headings and unnessisary comments Created Nov. 12, 2016, 12:46 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 /*!

	2 * This file is part of universal-design-language

	3 * Copyright (C) 2016 Eyeo GmbH

	4 *

	5 * universal-design-language is free software: you can redistribute it and/or

	6 * modify it under the terms of the GNU General Public License as published by

	7 * the Free Software Foundation, either version 3 of the License, or

	8 * (at your option) any later version.

	9 *

	10 * universal-design-language is distributed in the hope that it will be useful,

	11 * but WITHOUT ANY WARRANTY; without even the implied warranty of

	12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	13 * GNU General Public License for more details.

	14 *

	15 * You should have received a copy of the GNU General Public License

	16 * along with web.starter-kit. If not, see <http://www.gnu.org/licenses/>.

	17 */

	18

	19 /* UDL variables

	20 *******************************************************************************

	21 * - Basic colors

	22 * - Brand colors

	23 * - Fonts

	24 * - Spacing

	25 * - Breakpoints

	26 ******************************************************************************/

	27

	28 /* Basic colors
	saroyanm 2016/11/15 14:28:57 Do we need this ? I thought people will use brand Do we need this ? I thought people will use brand colors and adjust them according to the website/project. juliandoucette 2016/11/16 14:58:52 Acknowledged. We will create variations of brand Show quoted text On 2016/11/15 14:28:57, saroyanm wrote: > Do we need this ? I thought people will use brand colors and adjust them > according to the website/project. Acknowledged. We will create variations of brand colors as-needed instead. juliandoucette 2016/11/17 16:09:39 Done. Show quoted text On 2016/11/16 14:58:52, juliandoucette wrote: > On 2016/11/15 14:28:57, saroyanm wrote: > > Do we need this ? I thought people will use brand colors and adjust them > > according to the website/project. > > Acknowledged. > > We will create variations of brand colors as-needed instead. Done.
	29 ******************************************************************************/

	30

	31 $white: #fafafa !default;

	32 $gray-light: #e0e0e0 !default;

	33 $gray: #9e9e9e !default;

	34 $gray-dark: #616161 !default;

	35 $black: #212121 !default;

	36

	37 $red-light: #ffcdd2 !default;

	38 $red: #f44336 !default;

	39 $red-dark: #b71c1c !default;

	40

	41 $green-light: #c8e6c9 !default;

	42 $green: #4caf50 !default;

	43 $green-dark: #1b5e20 !default;

	44

	45 $blue-light: #bbdefb !default;

	46 $blue: #2196f3 !default;

	47 $blue-dark: #0d47a1 !default;

	48

	49 /* Brand colors

	50 ******************************************************************************/

	51

	52 /* Primary - The most widely used across all screens and components. */

	53

	54 $primary: $white !default;
	saroyanm 2016/11/15 14:28:58 Do we have a process of overriding the default var Do we have a process of overriding the default variables ? I think if we will only use this file to change the variables we do not need to setup default values ? How you imagine the override process and why are we using defaults here ? juliandoucette 2016/11/16 14:58:51 Acknowledged. We will add a DO NOT EDIT comment i Show quoted text On 2016/11/15 14:28:58, saroyanm wrote: > Do we have a process of overriding the default variables ? I think if we will > only use this file to change the variables we do not need to setup default > values ? How you imagine the override process and why are we using defaults here > ? Acknowledged. We will add a DO NOT EDIT comment in this file explaining how SCSS variables work. juliandoucette 2016/11/17 16:09:39 Done. Show quoted text On 2016/11/16 14:58:51, juliandoucette wrote: > On 2016/11/15 14:28:58, saroyanm wrote: > > Do we have a process of overriding the default variables ? I think if we will > > only use this file to change the variables we do not need to setup default > > values ? How you imagine the override process and why are we using defaults > here > > ? > > Acknowledged. > > We will add a DO NOT EDIT comment in this file explaining how SCSS variables > work. Done.
	55 $primary-foreground: $black !default;

	56 $primary-background: $white !default;

	57

	58 /* Secondary - Used to indicate a related action or information. */

	59

	60 $secondary: $gray-dark !default;

	61 $secondary-foreground: $gray-light !default;

	62 $secondary-background: $gray-dark !default;

	63

	64 /* Accent - Used for action buttons and interactive elements. */

	65

	66 $accent: $blue !default;

	67 $accent-foreground: $white !default;

	68 $accent-background: $blue-dark !default;

	69

	70 /* Error - Used for error messages and warnings. */

	71

	72 $error: $red !default;

	73 $error-foreground: $white !default;

	74 $error-background: $red-dark !default;

	75

	76 /* Fonts

	77 ******************************************************************************/

	78

	79 $sans-font: sans-serif !default;
	saroyanm 2016/11/15 14:28:58 Detail: having variable with the same names as the Detail: having variable with the same names as the font itself doesn't make much sense I think, we need to understand where the font will be used to make the naming consistent. juliandoucette 2016/11/16 14:58:51 Acknowledged. We will change these to primary/sec Show quoted text On 2016/11/15 14:28:58, saroyanm wrote: > Detail: having variable with the same names as the font itself doesn't make much > sense I think, we need to understand where the font will be used to make the > naming consistent. Acknowledged. We will change these to primary/secondary instead of sans/serif. juliandoucette 2016/11/17 16:09:39 Done. Show quoted text On 2016/11/16 14:58:51, juliandoucette wrote: > On 2016/11/15 14:28:58, saroyanm wrote: > > Detail: having variable with the same names as the font itself doesn't make > much > > sense I think, we need to understand where the font will be used to make the > > naming consistent. > > Acknowledged. > > We will change these to primary/secondary instead of sans/serif. Done.
	80 $serif-font: serif !default;
	saroyanm 2016/11/15 14:28:58 I can't see this font being used in content. I can't see this font being used in content. juliandoucette 2016/11/16 14:58:52 Acknowledged. Show quoted text On 2016/11/15 14:28:58, saroyanm wrote: > I can't see this font being used in content. Acknowledged.
	81 $monospace-font: monospace !default;

	82

	83 $large-font: 20px !default;

	84 $medium-font: 16px !default;

	85 $small-font: 12px !default;

	86

	87 $bold-weight: 600 !default;

	88 $normal-weight: 400 !default;

	89 $thin-weight: 300 !default;

	90

	91 /* Spacing

	92 ******************************************************************************/

	93

	94 $large-space: 64px !default;

	95 $medium-space: 32px !default;

	96 $small-space: 16px !default;

	97

	98 /* Breakpoints

	99 ******************************************************************************/

	100

	101 $mobile-breakpoint: 576px !default;
	juliandoucette 2016/11/17 16:09:39 Done. Done. juliandoucette 2016/11/17 16:09:40 NOTE: Removed mobile breakpoint. NOTE: Removed mobile breakpoint.
	102 $tablet-breakpoint: 768px !default;

	103 $desktop-breakpoint: 992px !default;

	104

	105 /* Container widths

	106 ******************************************************************************/

	107

	108 $mobile-width: 540px !default;

	109 $tablet-width: 720px !default;

	110 $desktop-width: 960px !default;

OLD	NEW

« scss/_content.scss ('K') | « scss/_reset.scss ('k') | scss/main.scss » ('j') | no next file with comments »