scss/main.scss - Issue 29361647: Issue 4607 - Default content styles

Delta Between Two Patch Sets: scss/main.scss

Issue 29361647: Issue 4607 - Default content styles (Closed)

Left Patch Set: Removed missing grid dependency. Created Nov. 3, 2016, 5:48 p.m.

Right Patch Set: See comments for details Created Dec. 1, 2016, 2:05 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*!	1 /*!

2 * This file is part of universal-design-language	2 * This file is part of website-defaults

3 * Copyright (C) 2016 Eyeo GmbH	3 * Copyright (C) 2016 Eyeo GmbH

4 *	4 *

5 * universal-design-language is free software: you can redistribute it and/or	5 * website-defaults is free software: you can redistribute it and/or

6 * modify it under the terms of the GNU General Public License as published by	6 * modify it under the terms of the GNU General Public License as published by

7 * the Free Software Foundation, either version 3 of the License, or	7 * the Free Software Foundation, either version 3 of the License, or

8 * (at your option) any later version.	8 * (at your option) any later version.

9 *	9 *

10 * universal-design-language is distributed in the hope that it will be useful,	10 * website-defaults is distributed in the hope that it will be useful,

11 * but WITHOUT ANY WARRANTY; without even the implied warranty of	11 * but WITHOUT ANY WARRANTY; without even the implied warranty of

12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

13 * GNU General Public License for more details.	13 * GNU General Public License for more details.

14 *	14 *

15 * You should have received a copy of the GNU General Public License	15 * You should have received a copy of the GNU General Public License

16 * along with web.starter-kit. If not, see <http://www.gnu.org/licenses/>.	16 * along with website-defaults. If not, see <http://www.gnu.org/licenses/>.

17 */	17 */

18	18

19 @import "../node_modules/normalize.css/normalize";
saroyanm 2016/11/03 19:41:15 Normalize css have a lot of styles that we probabl Normalize css have a lot of styles that we probably will not use, I'll suggest to use only styles that we need. We can add more, in case needed. I can't comment on each particular style while it's not included in the review. juliandoucette 2016/11/03 22:59:39 I would caution us against forking a sudo-standard Show quoted text On 2016/11/03 19:41:15, saroyanm wrote: > Normalize css have a lot of styles that we probably will not use, I'll suggest > to use only styles that we need. We can add more, in case needed. > I can't comment on each particular style while it's not included in the review. I would caution us against forking a sudo-standard library like this. The point of using normalize is that we trust this library to equalize browsers and handle edge cases so that we don't have to. https://github.com/necolas/normalize.css/ saroyanm 2016/11/04 16:01:18 It handles not only edge cases we need, but the on Show quoted text On 2016/11/03 22:59:39, juliandoucette wrote: > On 2016/11/03 19:41:15, saroyanm wrote: > > Normalize css have a lot of styles that we probably will not use, I'll suggest > > to use only styles that we need. We can add more, in case needed. > > I can't comment on each particular style while it's not included in the > review. > > I would caution us against forking a sudo-standard library like this. The point > of using normalize is that we trust this library to equalize browsers and handle > edge cases so that we don't have to. > > https://github.com/necolas/normalize.css/ It handles not only edge cases we need, but the one that we might not use at all, if we consider that logic we will end up loading bunch of CSS JS which will handle all the stuff for us. I kinda feel like that we end up fixing stuff caused by third party libraries. If you want we can ask for 3-rd opinion here. juliandoucette 2016/11/04 17:32:27 We'll pick and choose into _reset.scss (or whateve Show quoted text On 2016/11/04 16:01:18, saroyanm wrote: > On 2016/11/03 22:59:39, juliandoucette wrote: > > On 2016/11/03 19:41:15, saroyanm wrote: > > > Normalize css have a lot of styles that we probably will not use, I'll > suggest > > > to use only styles that we need. We can add more, in case needed. > > > I can't comment on each particular style while it's not included in the > > review. > > > > I would caution us against forking a sudo-standard library like this. The > point > > of using normalize is that we trust this library to equalize browsers and > handle > > edge cases so that we don't have to. > > > > https://github.com/necolas/normalize.css/ > > It handles not only edge cases we need, but the one that we might not use at > all, if we consider that logic we will end up loading bunch of CSS JS which will > handle all the stuff for us. I kinda feel like that we end up fixing stuff > caused by third party libraries. If you want we can ask for 3-rd opinion here. We'll pick and choose into _reset.scss (or whatever we name it). juliandoucette 2016/11/08 15:52:01 Done. Show quoted text On 2016/11/04 17:32:27, juliandoucette wrote: > On 2016/11/04 16:01:18, saroyanm wrote: > > On 2016/11/03 22:59:39, juliandoucette wrote: > > > On 2016/11/03 19:41:15, saroyanm wrote: > > > > Normalize css have a lot of styles that we probably will not use, I'll > > suggest > > > > to use only styles that we need. We can add more, in case needed. > > > > I can't comment on each particular style while it's not included in the > > > review. > > > > > > I would caution us against forking a sudo-standard library like this. The > > point > > > of using normalize is that we trust this library to equalize browsers and > > handle > > > edge cases so that we don't have to. > > > > > > https://github.com/necolas/normalize.css/ > > > > It handles not only edge cases we need, but the one that we might not use at > > all, if we consider that logic we will end up loading bunch of CSS JS which > will > > handle all the stuff for us. I kinda feel like that we end up fixing stuff > > caused by third party libraries. If you want we can ask for 3-rd opinion here. > > We'll pick and choose into _reset.scss (or whatever we name it). Done.
20 @import "variables";	19 @import "variables";

21 @import "reset";	20 @import "base";

22 @import "content";	21 @import "content";

LEFT	RIGHT