package.json - Issue 29361647: Issue 4607 - Default content styles

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: package.json

Issue 29361647: Issue 4607 - Default content styles (Closed)

Left Patch Set: Added container & simplified html/scss Created Nov. 10, 2016, 1:22 p.m.

Right Patch Set: See comments for details Created Dec. 1, 2016, 2:05 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {	1 {

2 "name": "universal-design-language",	2 "name": "website-defaults",

3 "description": "Universal styles for Eyeo websites",	3 "description": "Sensible defaults for Eyeo websites",

4 "version": "1.0.0",	4 "version": "1.0.0",

5 "license": "GPL-3.0",	5 "license": "GPL-3.0",

6 "contributors": [	6 "contributors": [

7 "Julian Doucette <julian@adblockplus.org>",	7 "Julian Doucette <j.doucette@eyeo.com>",

8 "Manvel Saroyan <manvel@adblockplus.org>"	8 "Manvel Saroyan <m.saroyan@eyeo.com>"

9 ],	9 ],

10 "devDependencies": {	10 "devDependencies": {

11 "gulp": "^3.9.1",	11 "gulp": "^3.9.1",

12 "gulp-connect": "^5.0.0",	12 "gulp-connect": "^5.0.0",

13 "gulp-htmlhint": "^0.3.1",	13 "gulp-sass": "^2.3.2"
saroyanm 2016/11/10 16:30:43 I'll suggest, not to include htmlhint and lint in I'll suggest, not to include htmlhint and lint in current review, they are not making the review finish process easier IMO, I'll suggest to add "nice to have" features in separate reviews. juliandoucette 2016/11/10 17:42:06 Acknowledged. Show quoted text On 2016/11/10 16:30:43, saroyanm wrote: > I'll suggest, not to include htmlhint and lint in current review, they are not > making the review finish process easier IMO, I'll suggest to add "nice to have" > features in separate reviews. Acknowledged. juliandoucette 2016/11/11 16:27:08 Done. Show quoted text On 2016/11/10 17:42:06, juliandoucette wrote: > On 2016/11/10 16:30:43, saroyanm wrote: > > I'll suggest, not to include htmlhint and lint in current review, they are not > > making the review finish process easier IMO, I'll suggest to add "nice to > have" > > features in separate reviews. > > Acknowledged. Done.
14 "gulp-sass": "^2.3.2",

15 "gulp-sourcemaps": "^2.2.0",

16 "gulp-stylelint": "^3.4.0"
saroyanm 2016/11/10 16:30:42 Getting current error: No configuration provided f Getting current error: No configuration provided for /_content.scss juliandoucette 2016/11/10 17:42:05 Acknowledged. Show quoted text On 2016/11/10 16:30:42, saroyanm wrote: > Getting current error: > No configuration provided for /_content.scss Acknowledged. juliandoucette 2016/11/11 16:27:09 Done. Show quoted text On 2016/11/10 17:42:05, juliandoucette wrote: > On 2016/11/10 16:30:42, saroyanm wrote: > > Getting current error: > > No configuration provided for /_content.scss > > Acknowledged. Done.
17 }	14 }

18 }	15 }

LEFT	RIGHT