Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(789)

Issue 29361668: Issue 4394 - Create a filter class for element hiding emulation filters (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by Felix Dahlke
Modified:
1 year ago
Reviewers:
Wladimir Palant, kzar
Base URL:
https://bitbucket.org/fhd/adblockpluscore
Visibility:
Public.

Description

Issue 4394 - Create a filter class for element hiding emulation filters

Patch Set 1 #

Total comments: 36

Patch Set 2 : Address kzar's comments #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Address Wladimir's comments #

Total comments: 8

Patch Set 5 : Address kzar's comments #

Patch Set 6 : Improve compliance with the 80 column rule #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -180 lines) Patch
M chrome/content/elemHideEmulation.js View 1 2 3 4 chunks +29 lines, -9 lines 0 comments Download
A lib/common.js View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download
M lib/elemHideEmulation.js View 1 chunk +8 lines, -8 lines 0 comments Download
M lib/filterClasses.js View 1 2 3 4 6 chunks +14 lines, -88 lines 0 comments Download
M lib/filterListener.js View 4 chunks +7 lines, -7 lines 0 comments Download
M test/elemHideEmulation.js View 1 2 chunks +17 lines, -15 lines 0 comments Download
M test/filterClasses.js View 1 2 3 4 5 7 chunks +28 lines, -38 lines 0 comments Download
M test/filterListener.js View 4 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 28
Felix Dahlke
1 year, 1 month ago (2016-11-03 15:42:43 UTC) #1
Felix Dahlke
1 year, 1 month ago (2016-11-03 15:47:13 UTC) #2
Felix Dahlke
Some pointers: 1. The biggest part here is a renaming from CSS Property Filter to ...
1 year, 1 month ago (2016-11-03 15:58:50 UTC) #3
kzar
(Just looking through these reviews today, sorry for the delay.) On 2016/11/03 15:58:50, Felix Dahlke ...
1 year, 1 month ago (2016-11-04 13:20:00 UTC) #4
Felix Dahlke
On 2016/11/04 13:20:00, kzar wrote: > (Just looking through these reviews today, sorry for the ...
1 year, 1 month ago (2016-11-04 13:37:57 UTC) #5
kzar
https://codereview.adblockplus.org/29361668/diff/29361669/chrome/content/elemHideEmulation.js File chrome/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29361668/diff/29361669/chrome/content/elemHideEmulation.js#newcode134 chrome/content/elemHideEmulation.js:134: if (pattern.features != elemHideEmulationFeatureMap.PROPERTY_SELECTOR) Before I suggested adding a ...
1 year, 1 month ago (2016-11-04 15:45:56 UTC) #6
Felix Dahlke
I've responded to all comments, but I haven't uploaded a new patch set yet, since ...
1 year, 1 month ago (2016-11-04 16:43:35 UTC) #7
kzar
https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js#newcode918 lib/filterClasses.js:918: if (selector.indexOf(":has(") != -1) I guess my question is ...
1 year, 1 month ago (2016-11-07 12:36:26 UTC) #8
Felix Dahlke
https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js#newcode918 lib/filterClasses.js:918: if (selector.indexOf(":has(") != -1) On 2016/11/07 12:36:26, kzar wrote: ...
1 year, 1 month ago (2016-11-07 14:41:25 UTC) #9
kzar
https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js#newcode918 lib/filterClasses.js:918: if (selector.indexOf(":has(") != -1) On 2016/11/07 14:41:24, Felix Dahlke ...
1 year, 1 month ago (2016-11-07 15:59:44 UTC) #10
Felix Dahlke
https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js#newcode918 lib/filterClasses.js:918: if (selector.indexOf(":has(") != -1) On 2016/11/07 15:59:44, kzar wrote: ...
1 year, 1 month ago (2016-11-07 16:51:24 UTC) #11
kzar
https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js#newcode918 lib/filterClasses.js:918: if (selector.indexOf(":has(") != -1) On 2016/11/07 16:51:24, Felix Dahlke ...
1 year, 1 month ago (2016-11-07 17:10:22 UTC) #12
kzar
https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js#newcode928 lib/filterClasses.js:928: return new ElemHideEmulationFilter(text, domain, selector, On 2016/11/04 16:43:35, Felix ...
1 year, 1 month ago (2016-11-07 17:19:26 UTC) #13
Felix Dahlke
Some comment responses, but I guess I have enough now to work on the next ...
1 year, 1 month ago (2016-11-08 17:45:35 UTC) #14
Felix Dahlke
New patch set is up, all comments addressed AFAICT. Note that I haven't rebased this ...
1 year, 1 month ago (2016-11-11 11:51:43 UTC) #15
kzar
> Note that I haven't rebased this on top of #4593, since I > want ...
1 year ago (2016-11-15 16:54:13 UTC) #16
Felix Dahlke
Rebased, I believe everything has been addressed now, except for the open discussion where we ...
1 year ago (2016-11-15 21:11:45 UTC) #17
kzar
On 2016/11/15 21:11:45, Felix Dahlke wrote: > But we're moving in circles again, so let's ...
1 year ago (2016-11-16 10:53:40 UTC) #18
Felix Dahlke
On 2016/11/16 10:53:40, kzar wrote: > On 2016/11/15 21:11:45, Felix Dahlke wrote: > > But ...
1 year ago (2016-11-16 10:59:18 UTC) #19
kzar
On 2016/11/16 10:59:18, Felix Dahlke wrote: > but in general I find your reviews valuable ...
1 year ago (2016-11-16 11:10:17 UTC) #20
Wladimir Palant
https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js#newcode918 lib/filterClasses.js:918: if (selector.indexOf(":has(") != -1) I actually have to agree ...
1 year ago (2016-11-21 11:39:15 UTC) #21
Felix Dahlke
New patch set is up, all comments should be addressed. https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.js#newcode918 ...
1 year ago (2016-11-21 14:38:59 UTC) #22
kzar
https://codereview.adblockplus.org/29361668/diff/29363652/lib/common.js File lib/common.js (right): https://codereview.adblockplus.org/29361668/diff/29363652/lib/common.js#newcode49 lib/common.js:49: if (typeof exports != "undefined") Nit: The braces here ...
1 year ago (2016-11-21 16:24:55 UTC) #23
Felix Dahlke
Thanks Dave, new patch set is up! https://codereview.adblockplus.org/29361668/diff/29363652/lib/common.js File lib/common.js (right): https://codereview.adblockplus.org/29361668/diff/29363652/lib/common.js#newcode49 lib/common.js:49: if (typeof ...
1 year ago (2016-11-21 17:26:13 UTC) #24
kzar
https://codereview.adblockplus.org/29361668/diff/29363652/test/filterClasses.js File test/filterClasses.js (right): https://codereview.adblockplus.org/29361668/diff/29363652/test/filterClasses.js#newcode43 test/filterClasses.js:43: ElemHideException, ElemHideEmulationFilter} = sandboxedRequire("../lib/filterClasses") On 2016/11/21 17:26:12, Felix Dahlke ...
1 year ago (2016-11-21 19:18:23 UTC) #25
Felix Dahlke
New patch set is up. https://codereview.adblockplus.org/29361668/diff/29363652/test/filterClasses.js File test/filterClasses.js (right): https://codereview.adblockplus.org/29361668/diff/29363652/test/filterClasses.js#newcode43 test/filterClasses.js:43: ElemHideException, ElemHideEmulationFilter} = sandboxedRequire("../lib/filterClasses") ...
1 year ago (2016-11-21 20:11:48 UTC) #26
kzar
LGTM
1 year ago (2016-11-21 22:35:17 UTC) #27
Wladimir Palant
1 year ago (2016-11-22 08:40:37 UTC) #28
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5