Issue 4394 - Create a filter class for element hiding emulation filters

chrome/content/elemHideEmulation.js

+var propertySelectorRegExp = /\[\-abp\-properties=(["'])([^"']+)\1\]/;
+
 function splitSelector(selector)
 {
   if (selector.indexOf(",") == -1)
     return [selector];
 
   var selectors = [];
   var start = 0;
   var level = 0;
   var sep = "";
 
@@ skipping 109 matching lines @@
   },
 
   load: function(callback)
   {
     this.getFiltersFunc(function(patterns)
     {
       this.patterns = [];
       for (var i = 0; i < patterns.length; i++)
       {
         var pattern = patterns[i];
-
-        // We currently don't support any element hiding emulation feature
-        // except for property selectors, so we remove rules that use other
-        // features. See https://issues.adblockplus.org/ticket/3143.
-        if (pattern.features != elemHideEmulationFeatureMap.PROPERTY_SELECTOR)
-          continue;
-
-        var propertySelectorRegExp = /\[\-abp\-properties=(["'])([^"']+)\1\]/;

[Wladimir Palant, 2016/11/21 11:39:15]

This regexp should be created outside the loop, ideally even outside the
function.

[Felix Dahlke, 2016/11/21 14:38:59]

Done.

         var match = propertySelectorRegExp.exec(pattern.selector);
         if (!match)
           continue;
 
         var propertyExpression = match[2];
         var regexpString;
         if (propertyExpression.length >= 2 && propertyExpression[0] == "/" &&
             propertyExpression[propertyExpression.length - 1] == "/")
           regexpString = propertyExpression.slice(1, -1);
         else
@@ skipping 14 matching lines @@
   apply: function()
   {
     if (this.patterns.length > 0)
     {
       var document = this.window.document;
       this.addSelectors(document.styleSheets);
       document.addEventListener("load", this.onLoad.bind(this), true);
     }
   }
 };