Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(486)

Issue 29361722: Issue 4592 - Adapt messaging code for the new element hiding emulation filters (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by Felix Dahlke
Modified:
3 years, 4 months ago
Base URL:
https://bitbucket.org/fhd/adblockplusui
Visibility:
Public.

Description

Issue 4592 - Adapt messaging code for the new element hiding emulation filters

Patch Set 1 #

Total comments: 2

Patch Set 2 : Wrap long line #

Total comments: 4

Patch Set 3 : Remove features property #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M background.js View 1 chunk +2 lines, -2 lines 0 comments Download
M messageResponder.js View 1 2 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 9
Felix Dahlke
3 years, 5 months ago (2016-11-03 18:21:05 UTC) #1
Felix Dahlke
Some fairly simple changes that accompany https://codereview.adblockplus.org/29361668/.
3 years, 5 months ago (2016-11-03 18:25:08 UTC) #2
kzar
Otherwise LGTM. (Assuming we do go ahead with parsing emulation filters on the content script ...
3 years, 5 months ago (2016-11-04 14:37:21 UTC) #3
Felix Dahlke
Thanks, new patch set is up. I will land #4394 before I land this. https://codereview.adblockplus.org/29361722/diff/29361723/messageResponder.js ...
3 years, 5 months ago (2016-11-04 17:38:46 UTC) #4
Thomas Greiner
LGTM, just a small suggestion I added. https://codereview.adblockplus.org/29361722/diff/29361741/background.js File background.js (right): https://codereview.adblockplus.org/29361722/diff/29361741/background.js#newcode320 background.js:320: getRulesForDomain: function(domain) ...
3 years, 4 months ago (2016-11-07 13:27:08 UTC) #5
Felix Dahlke
Removed the `features` property since we removed it in https://codereview.adblockplus.org/29361668/. https://codereview.adblockplus.org/29361722/diff/29361741/background.js File background.js (right): https://codereview.adblockplus.org/29361722/diff/29361741/background.js#newcode320 ...
3 years, 4 months ago (2016-11-21 17:33:06 UTC) #6
kzar
LGTM https://codereview.adblockplus.org/29361722/diff/29361741/background.js File background.js (right): https://codereview.adblockplus.org/29361722/diff/29361741/background.js#newcode320 background.js:320: getRulesForDomain: function(domain) { } IMO if it's not ...
3 years, 4 months ago (2016-11-21 19:14:59 UTC) #7
Thomas Greiner
LGTM https://codereview.adblockplus.org/29361722/diff/29361741/background.js File background.js (right): https://codereview.adblockplus.org/29361722/diff/29361741/background.js#newcode320 background.js:320: getRulesForDomain: function(domain) { } On 2016/11/21 17:33:06, Felix ...
3 years, 4 months ago (2016-11-22 12:04:10 UTC) #8
Wladimir Palant
3 years, 4 months ago (2016-11-22 12:07:20 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5