Issue 4574 - Adds Tests to createNightlies platform specific revisions

sitescripts/extensions/test/test_createNightlies.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2016 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 """Tests for create nightlies script."""
+import os
+from subprocess import CalledProcessError
+
 import pytest
 
 from sitescripts.extensions.bin import createNightlies
 from sitescripts.utils import get_config
 

[Vasily Kuznetsov, 2016/11/14 19:42:38]

We should probably also have a test for `getChanges` here. Having it in the
first place would perhaps have prevented #4605 but oh well, at least this will
hopefully help us next time.

[Jon Sonesen, 2016/11/15 11:18:46]

Yesh that was an oversight on my part will write a test for this.

 
-@pytest.fixture()
+@pytest.fixture(scope='session')
 def config(hg_dir):
+    """Set and return config obj for NightlyBuild"""
     config = get_config()
     config.type = 'safari'
-    config.repository = str(hg_dir.join('adblockplusnightly'))
     config.revision = 'safari'
+    config.repositoryName = 'adblockplusnightly'
+    config.repository = hg_dir.join('adblockplusnightly').strpath

[Vasily Kuznetsov, 2016/11/14 19:42:38]

This seems to be `nightly_dir`.

[Jon Sonesen, 2016/11/15 11:18:47]

it is

     return config
 
 
-@pytest.fixture()
+@pytest.fixture(scope='session')
 def nightlybuild(config):
     return createNightlies.NightlyBuild(config)
 
 
+@pytest.fixture(scope='session')
+def current_revision(nightlydir):
+    return '1291590ddd0f'
+
+
 def test_nightly_object_bookmark(nightlybuild):
     assert nightlybuild.config.revision == 'safari'
+
+
+def test_current_revision(current_revision, nightlybuild):
+    assert nightlybuild.revision == current_revision
+
+
+def test_copy_repository(nightlybuild, nightlydir):
+    nightlybuild.copyRepository()
+    assert os.listdir(nightlybuild.tempdir) == os.listdir(nightlydir.strpath)
+
+
+def test_missing_bookmark(config):
+    config.revision = 'foo'
+    config.type = 'type'
+    try:
+        createNightlies.NightlyBuild(config)
+    except CalledProcessError as e:
+        assert e.returncode == 255