Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: chrome/devtools.js

Issue 29362526: Issue 4644 - Pass search messages to our devtools panel (Closed)
Patch Set: Created Nov. 14, 2016, 7:56 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 var panelWindow = null;
Sebastian Noack 2017/01/12 23:25:02 Is the panel (and it's window) a singleton? What i
Sebastian Noack 2017/01/12 23:25:02 Any reason to not use let (instead of var) here?
kzar 2017/01/13 08:30:08 Done.
kzar 2017/01/13 08:30:08 Good point, but I just tested and it works fine wi
21
20 chrome.runtime.sendMessage( 22 chrome.runtime.sendMessage(
21 { 23 {
22 type: "prefs.get", 24 type: "prefs.get",
23 key: "show_devtools_panel" 25 key: "show_devtools_panel"
24 }, 26 },
25 function(enabled) 27 function(enabled)
26 { 28 {
27 if (enabled) 29 if (enabled)
28 chrome.devtools.panels.create("Adblock Plus", 30 {
29 "icons/detailed/abp-48.png", 31 chrome.devtools.panels.create(
30 "devtools-panel.html"); 32 "Adblock Plus",
33 "icons/detailed/abp-48.png",
34 "devtools-panel.html",
35 function (panel)
Sebastian Noack 2017/01/12 23:25:02 I wonder whether we should use arrow functions her
kzar 2017/01/13 08:30:08 I think the rule is to use let and arrow functions
Sebastian Noack 2017/01/13 11:57:38 I tend to agree. Mind filing a review to add it to
36 {
37 panel.onShown.addListener(function(window)
38 {
39 panelWindow = window;
40 });
41
42 panel.onHidden.addListener(function(window)
43 {
44 panelWindow = null;
45 });
46
47 panel.onSearch.addListener(function(eventName, queryString)
48 {
49 if (panelWindow)
50 {
51 panelWindow.postMessage({
52 type: eventName,
53 queryString: queryString
54 }, "*");
55 }
56 });
57 }
58 );
59 }
31 } 60 }
32 ); 61 );
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld