Issue 4644 - Pass search messages to our devtools panel

chrome/devtools.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-var panelWindow = null;

[Sebastian Noack, 2017/01/12 23:25:02]

Is the panel (and it's window) a singleton? What if you use the developer tools
panel on multiple pages simultaneously?

[Sebastian Noack, 2017/01/12 23:25:02]

Any reason to not use let (instead of var) here?

[kzar, 2017/01/13 08:30:08]

Done.

[kzar, 2017/01/13 08:30:08]

Good point, but I just tested and it works fine with multiple windows. I think
devtools.js is run in it's own context for each developer tools window.

+let panelWindow = null;
 
 chrome.runtime.sendMessage(
   {
     type: "prefs.get",
     key: "show_devtools_panel"
   },
-  function(enabled)
+  enabled =>
   {
     if (enabled)
     {
       chrome.devtools.panels.create(
         "Adblock Plus",
         "icons/detailed/abp-48.png",
         "devtools-panel.html",
-        function (panel)

[Sebastian Noack, 2017/01/12 23:25:02]

I wonder whether we should use arrow functions here? Also I wonder what the rule
for using arrow functions in general should be? It seems in recent code (that
you wrote or reviewed) we use arrow functions for all anonymous function unless
we explicitly need no implicit binding.

[kzar, 2017/01/13 08:30:08]

I think the rule is to use let and arrow functions wherever possible now. I
should really get around to updating the existing code too, I'll try and open a
review for that today.

[Sebastian Noack, 2017/01/13 11:57:38]

I tend to agree. Mind filing a review to add it to
https://adblockplus.org/coding-style#javascript ?

+        panel =>
         {
-          panel.onShown.addListener(function(window)
+          panel.onShown.addListener(window =>
           {
             panelWindow = window;
           });
 
-          panel.onHidden.addListener(function(window)
+          panel.onHidden.addListener(window =>
           {
             panelWindow = null;
           });
 
-          panel.onSearch.addListener(function(eventName, queryString)
+          panel.onSearch.addListener((eventName, queryString) =>
           {
             if (panelWindow)
             {
               panelWindow.postMessage({
                 type: eventName,
                 queryString: queryString
               }, "*");
             }
           });
         }
       );
     }
   }
 );