modules/trac/files/trac_performance_fix.snippet - Issue 29362580: Issue 4641 - Append performance fix to trac cgi file

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: modules/trac/files/trac_performance_fix.snippet

Issue 29362580: Issue 4641 - Append performance fix to trac cgi file (Closed)

Patch Set: Issue 4641 - Performance fix to trac cgi file Created Nov. 16, 2016, 4:49 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 ### local modifications to the trac.fcgi file v1

	2 from trac.web.session import session

	3 orig_get = session.get

	4 def patched_get(self, key, default=none):
	mathias 2016/11/17 07:43:31 Typo: "None" vs. "none". Also, I guess it should b Typo: "None" vs. "none". Also, I guess it should be "Session" vs. "session" above and below? f.nicolaisen 2016/11/17 08:23:46 I don't know. This snippet was directly copied fro Show quoted text On 2016/11/17 07:43:31, mathias wrote: > Typo: "None" vs. "none". Also, I guess it should be "Session" vs. "session" > above and below? I don't know. This snippet was directly copied from the live Trac instance I believe, as described in issue 4641. mathias 2016/11/17 10:18:33 Well, I guess somewhere in the process the snippet Show quoted text On 2016/11/17 08:23:46, f.nicolaisen wrote: > On 2016/11/17 07:43:31, mathias wrote: > > Typo: "None" vs. "none". Also, I guess it should be "Session" vs. "session" > > above and below? > > I don't know. This snippet was directly copied from the live Trac instance I > believe, as described in issue 4641. Well, I guess somewhere in the process the snippet lost upper-case letters. The version in the ticket does not have the typos mentioned above. f.nicolaisen 2016/11/17 10:54:31 Wtf... OK, good thing you spotted this! I must've Show quoted text On 2016/11/17 10:18:33, mathias wrote: > On 2016/11/17 08:23:46, f.nicolaisen wrote: > > On 2016/11/17 07:43:31, mathias wrote: > > > Typo: "None" vs. "none". Also, I guess it should be "Session" vs. "session" > > > above and below? > > > > I don't know. This snippet was directly copied from the live Trac instance I > > believe, as described in issue 4641. > > Well, I guess somewhere in the process the snippet lost upper-case letters. The > version in the ticket does not have the typos mentioned above. Wtf... OK, good thing you spotted this! I must've accidentally hit ~ while the block was selected in vim or something. Really weird.
	5 if key == 'accesskeys':

	6 return '1'

	7 return orig_get(self, key, default)

	8 session.get = patched_get

	9 ### end of local modifications

OLD	NEW

« no previous file with comments | « no previous file | modules/trac/manifests/init.pp » ('j') | modules/trac/manifests/init.pp » ('J')