Issue 2879 - Restructure existing process script, split it up into multiple modules

lib/child/actor.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
 "use strict";
 
 let console;

[saroyanm, 2016/11/22 14:58:31]

Why do we load console ? Are we outputing/planing to output smth there ?

[Wladimir Palant, 2016/11/24 14:16:29]

We are not, this is a debugging helper. In fact, I am considering changing
module scopes so that we would generally have a console objects - would be more
consistent than using Cu.reportError().

[saroyanm, 2016/11/24 17:46:10]

Acknowledged.

 try
 {
   // Gecko 44+
   ({console} = Cu.import("resource://gre/modules/Console.jsm", {}));
 }
 catch (e)
 {
   ({console} = Cu.import("resource://gre/modules/devtools/Console.jsm", {}));
 }
 
 let DebuggerServer;
 try
 {
   // Firefox 44+
   let {require} = Cu.import("resource://devtools/shared/Loader.jsm", {});
   ({DebuggerServer} = require("devtools/server/main"));
 }
 catch (e)
 {
   ({DebuggerServer} = Cu.import("resource://gre/modules/devtools/dbg-server.jsm", {}));
 }
 
 let {getNodeInfo} = require("./nodeInfo");
 
+function Actor(connection, tabActor)
+{
+}
+
+Actor.prototype = {
+  requestTypes: {
+    nodeinfo: function(request, connection)
+    {
+      let nodeActor = connection.getActor(request.nodeActor);
+      return getNodeInfo(nodeActor ? nodeActor.rawNode : null);
+    }
+  }
+};
+
 let name = "elemhidehelper";
 let actor = {
   constructorFun: Actor,
   constructorName: name,
   name: name
 };
 
 DebuggerServer.addTabActor(actor, name);
 onShutdown.add(() =>
 {
   try
   {
     DebuggerServer.removeTabActor(actor);
   }
   catch (e)
   {
     // The call above will throw in the content process despite succeeding,
     // see https://bugzilla.mozilla.org/show_bug.cgi?id=1189780.
     Cu.reportError(e);
   }
 });
-
-function Actor(connection, tabActor)

[saroyanm, 2016/11/22 14:58:31]

Detail: Why do we need this empty constructor ?
At least we are not using the parameters inside.

[saroyanm, 2016/11/22 14:58:31]

Detail: Maybe it's personal preference, but what about moving the constructor
and prototype on top of the the actor variable declaration for readability
reasons[I do not feel strong about suggestion].

[Wladimir Palant, 2016/11/24 14:16:29]

Well, DebuggerServer.addTabActor() requires a constructor - it will create
objects are necessary. The parameters aren't used but they are being passed in
by the developer tools nevertheless.

On 2016/11/22 14:58:31, saroyanm wrote:
Done.

[saroyanm, 2016/11/24 17:46:10]

Acknowledged.

-{
-}
-
-Actor.prototype = {
-  requestTypes: {
-    nodeinfo: function(request, connection)
-    {
-      let nodeActor = connection.getActor(request.nodeActor);
-      return getNodeInfo(nodeActor ? nodeActor.rawNode: null);

[saroyanm, 2016/11/22 14:58:31]

Detail: missing space after first expression.

[Wladimir Palant, 2016/11/24 14:16:29]

Done.

-    }
-  }
-};