Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29363535: Issue 2313 - Handle Flup dependency in module sitescripts (Closed)

Created:
Nov. 18, 2016, 9:47 a.m. by f.lopez
Modified:
Nov. 21, 2016, 9:30 a.m.
Reviewers:
mathias
Visibility:
Public.

Description

Issue 2313 - Handle Flup dependency in module sitescripts

Patch Set 1 #

Total comments: 1

Patch Set 2 : Issue 2313 - Handle Flup dependency in module sitescripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M modules/downloadserver/manifests/init.pp View 2 chunks +2 lines, -2 lines 0 comments Download
M modules/hgweb/manifests/init.pp View 1 chunk +1 line, -1 line 0 comments Download
M modules/notificationserver/manifests/init.pp View 2 chunks +0 lines, -2 lines 0 comments Download
M modules/sitescripts/manifests/init.pp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M modules/updateserver/manifests/init.pp View 2 chunks +0 lines, -2 lines 0 comments Download
M modules/web/manifests/server.pp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4
f.lopez
Nov. 18, 2016, 9:47 a.m. (2016-11-18 09:47:44 UTC) #1
mathias
Have you tested each module/role affected by the removed lines? https://codereview.adblockplus.org/29363535/diff/29363536/modules/sitescripts/manifests/init.pp File modules/sitescripts/manifests/init.pp (right): https://codereview.adblockplus.org/29363535/diff/29363536/modules/sitescripts/manifests/init.pp#newcode26 ...
Nov. 18, 2016, 10:59 a.m. (2016-11-18 10:59:03 UTC) #2
f.lopez
On 2016/11/18 10:59:03, mathias wrote: > Have you tested each module/role affected by the removed ...
Nov. 18, 2016, 3:39 p.m. (2016-11-18 15:39:57 UTC) #3
mathias
Nov. 18, 2016, 4:22 p.m. (2016-11-18 16:22:46 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld