Issue 4552 - Drop jshydra dependency (buildtools)

templates/modules.js.tmpl

+{%- if args["module"] -%}

[kzar, 2016/11/18 17:25:48]

I went without indentation since it made the rendered output nicer. Otherwise I
had to pick between no newline and newline with indentation spaces and that made
things ugly fast.

+{%- for module_name, script in modules -%}
+require.modules[{{ module_name|json|safe }}] = function(module, exports, require)

[Wladimir Palant, 2016/11/30 11:39:32]

No point passing in require as parameter, the globally defined require function
will do for now.

[kzar, 2016/11/30 14:29:45]

Done.

+{
+{{ script|safe }}

[Wladimir Palant, 2016/11/30 11:39:32]

Enabling autoescaping and then marking each variable as safe sort of defeats the
purpose of it ;)

[kzar, 2016/11/30 14:29:44]

Lol good point, done.

+return exports;

[Wladimir Palant, 2016/11/30 11:42:14]

This should return module.exports, in case the module decides to replace it by
its own object (which is valid with CommonJS).

[kzar, 2016/11/30 14:29:44]

Done.

+};
+
+{% endfor -%}
+{% for module_name, script in modules -%}

[Wladimir Palant, 2016/11/30 11:39:32]

This should be {%- for ... -%}, no point adding an extra newline here.

[kzar, 2016/11/30 14:29:45]

Done.

+{%- if module_name in args["autoload"] -%}

[Wladimir Palant, 2016/11/30 11:39:32]

This should not iterate over modules again, rather over args["autoload"]. The
autoload order should logically be defined by the autoload argument, not by the
module order.

[kzar, 2016/11/30 14:29:44]

Done.

+require({{ module_name|json|safe }});
+{% endif -%}
+{%- endfor %}
+{%- else -%}
+{%- for module_name, script in modules -%}
+{{ script|safe }}
+{%- endfor -%}
+{% endif %}

[Wladimir Palant, 2016/11/30 11:39:32]

This should be:

{% endfor -%}
{%- endif -%}

In other words, there should be a newline after each script, not only newlines
(currently two) at the end of file.

[kzar, 2016/11/30 14:29:44]

Done.