templates/modules.js.tmpl - Issue 29363565: Issue 4552 - Drop jshydra dependency (buildtools)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: templates/modules.js.tmpl

Issue 29363565: Issue 4552 - Drop jshydra dependency (buildtools) (Closed)

Left Patch Set: Addressed feedback, make tox pass Created Nov. 30, 2016, 2:23 p.m.

Right Patch Set: Check module exists before auto-loading it Created Nov. 30, 2016, 3:24 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {%- if args["module"] -%}	1 {%- if args["module"] -%}

2 {%- for module_name, script in modules -%}	2 {%- for module_name, script in modules -%}

3 require.modules[{{ module_name\|json }}] = function(module, exports)	3 require.modules[{{ module_name\|json }}] = function(module, exports)

4 {	4 {

5 {{ script }}	5 {{ script }}

6 return module.exports;	6 return module.exports;

7 };	7 };

8	8

9 {% endfor -%}	9 {% endfor -%}

	10 {%- set modules = dict(modules) -%}

10 {%- for module_name in args["autoload"] -%}	11 {%- for module_name in args["autoload"] -%}

	12 {%- if module_name in modules -%}

11 require({{ module_name\|json }});	13 require({{ module_name\|json }});
Wladimir Palant 2016/11/30 14:54:44 It's probably a good idea to check first whether t It's probably a good idea to check first whether the module exists, e.g. on Firefox we are currently removing popupBlocker module but it cannot be removed from autoload. Something like this: {%- set modules = dict(modules) -%} ... {%- if module_name in modules %-} kzar 2016/11/30 15:26:18 Done. Show quoted text On 2016/11/30 14:54:44, Wladimir Palant wrote: > It's probably a good idea to check first whether the module exists, e.g. on > Firefox we are currently removing popupBlocker module but it cannot be removed > from autoload. Something like this: > > {%- set modules = dict(modules) -%} > > ... > > {%- if module_name in modules %-} Done.
12 {% endfor %}	14 {% endif %}

	15 {%- endfor -%}

13 {%- else -%}	16 {%- else -%}

14 {%- for module_name, script in modules -%}	17 {%- for module_name, script in modules -%}

15 {{ script }}	18 {{ script }}

16 {% endfor -%}	19 {% endfor -%}
kzar 2016/11/30 14:29:45 `{%` not `{%-` so that the require calls are separ `{%` not `{%-` so that the require calls are separated by newlines.
17 {%- endif -%}	20 {%- endif -%}

LEFT	RIGHT