Issue 3789 - Default File $group to be root

Issue 3789 - Default File $group to be root

When provisioning locally using vagrant, files that have no explicit group
defined will end up with group ownership `vagrant`. By setting the default
to be group root at the top level, all files without specified group (including existing files)
will be changed to have group root during provisioning.

NOTE: This patch depends on https://codereview.adblockplus.org/29363759/ being applied in order to have the desired effect.

[f.lopez, 2016-11-22 14:46:39]

On 2016/11/22 14:21:33, f.nicolaisen wrote:

Please remove the unnecessary whitespace at the end of the file

[f.nicolaisen, 2016-11-22 14:52:29]

On 2016/11/22 14:46:39, f.lopez wrote:
> On 2016/11/22 14:21:33, f.nicolaisen wrote:
> 
> Please remove the unnecessary whitespace at the end of the file

As an old Git habit, I usually add a whitespace at EOF when modifying it:
http://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-ne...

According to https://adblockplus.org/en/coding-style - it says: "Newline at end
of file, otherwise no trailing whitespace."

Perhaps we should correct all files in one swoop to fix this, but I prefer
fixing it up as I'm changing the files in changes like these. What do you think?

[f.lopez, 2016-11-22 15:19:36]

On 2016/11/22 14:52:29, f.nicolaisen wrote:
> On 2016/11/22 14:46:39, f.lopez wrote:
> > On 2016/11/22 14:21:33, f.nicolaisen wrote:
> > 
> > Please remove the unnecessary whitespace at the end of the file
> 
> As an old Git habit, I usually add a whitespace at EOF when modifying it:
>
http://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-ne...
> 
> According to https://adblockplus.org/en/coding-style - it says: "Newline at
end
> of file, otherwise no trailing whitespace."
> 
> Perhaps we should correct all files in one swoop to fix this, but I prefer
> fixing it up as I'm changing the files in changes like these. What do you
think?

I agree but I'd rather have one task to fix the style since it is not related
with the ticket itself,
this way we don't modify unnecessary lines or mix the purpose of the commit.

[mathias, 2016-11-22 15:33:13]

https://codereview.adblockplus.org/29363762/diff/29363763/manifests/site.pp
File manifests/site.pp (right):

https://codereview.adblockplus.org/29363762/diff/29363763/manifests/site.pp#n...
manifests/site.pp:10: group => 'root',
Please use two spaces for indentation, thank you :)

[f.nicolaisen, 2016-11-22 15:48:50]

Not sure whether I should send another update after pushing, but I've fixed the
2 spaces and EOF line break now.

https://codereview.adblockplus.org/29363762/diff/29363763/manifests/site.pp
File manifests/site.pp (right):

https://codereview.adblockplus.org/29363762/diff/29363763/manifests/site.pp#n...
manifests/site.pp:10: group => 'root',
On 2016/11/22 15:33:13, mathias wrote:
> Please use two spaces for indentation, thank you :)

Acknowledged.

[mathias, 2016-11-22 16:16:00]

LGTM.