Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/filters-backup.js

Issue 29364102: Issue 4658 - Incorporate element hiding emulation filters (Closed) Base URL: https://bitbucket.org/fhd/adblockplus
Patch Set: Created Nov. 24, 2016, 9:41 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/content/ui/filters-filterview.js » ('j') | chrome/locale/en-US/global.properties » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/filters-backup.js
===================================================================
--- a/chrome/content/ui/filters-backup.js
+++ b/chrome/content/ui/filters-backup.js
@@ -312,25 +312,25 @@
list.push(filter.text);
if (filter instanceof ElemHideException && Services.vc.compare(minVersion, "2.1") < 0)
minVersion = "2.1";
if (filter instanceof RegExpFilter && filter.contentType & (RegExpFilter.typeMap.GENERICHIDE | RegExpFilter.typeMap.GENERICBLOCK) && Services.vc.compare(minVersion, "2.6.12") < 0)
minVersion = "2.6.12";
- if (filter instanceof CSSPropertyFilter && Services.vc.compare(minVersion, "2.7.3") < 0)
- minVersion = "2.7.3";
-
if (filter instanceof RegExpFilter &&
(filter.contentType & RegExpFilter.typeMap.WEBSOCKET) &&
Services.vc.compare(minVersion, "2.8"))
{
minVersion = "2.8";
}
+
+ if (filter instanceof ElemHideEmulationFilter && Services.vc.compare(minVersion, "2.9") < 0)
+ minVersion = "2.9";
Wladimir Palant 2016/12/13 14:44:27 No, as far as our users are concerned the syntax i
Felix Dahlke 2016/12/13 15:55:39 Acknowledged. (Oh boy, sounds like we'll have to r
Wladimir Palant 2016/12/13 16:33:03 No, this feature is purely informative - meaning t
}
}
list.unshift("[Adblock Plus " + minVersion + "]");
// Insert checksum. Have to add an empty line to the end of the list to
// account for the trailing newline in the file.
list.push("");
let checksum = Utils.generateChecksum(list);
« no previous file with comments | « no previous file | chrome/content/ui/filters-filterview.js » ('j') | chrome/locale/en-US/global.properties » ('J')

Powered by Google App Engine
This is Rietveld