chrome/content/ui/filters-backup.js - Issue 29364102: Issue 4658 - Incorporate element hiding emulation filters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/content/ui/filters-backup.js

Issue 29364102: Issue 4658 - Incorporate element hiding emulation filters (Closed) Base URL: https://bitbucket.org/fhd/adblockplus

Patch Set: Change minVersion back and improve error message Created Dec. 13, 2016, 3:52 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/content/ui/filters-backup.js

===================================================================

--- a/chrome/content/ui/filters-backup.js

+++ b/chrome/content/ui/filters-backup.js

@@ -312,17 +312,17 @@

list.push(filter.text);

if (filter instanceof ElemHideException && Services.vc.compare(minVersion, "2.1") < 0)

minVersion = "2.1";

if (filter instanceof RegExpFilter && filter.contentType & (RegExpFilter.typeMap.GENERICHIDE | RegExpFilter.typeMap.GENERICBLOCK) && Services.vc.compare(minVersion, "2.6.12") < 0)

minVersion = "2.6.12";

- if (filter instanceof CSSPropertyFilter && Services.vc.compare(minVersion, "2.7.3") < 0)

+ if (filter instanceof ElemHideEmulationFilter && Services.vc.compare(minVersion, "2.7.3") < 0)

minVersion = "2.7.3";

if (filter instanceof RegExpFilter &&

(filter.contentType & RegExpFilter.typeMap.WEBSOCKET) &&

Services.vc.compare(minVersion, "2.8"))

{

minVersion = "2.8";

}

« no previous file with comments | « no previous file | chrome/content/ui/filters-filterview.js » ('j') | no next file with comments »