Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: modules/fail2ban/templates/filter.erb
Issue
29364214
:
Issue 2487 - Introduce fail2ban module (Closed)
Left Patch Set: Issue 2487 - Introduce fail2ban module
Created Nov. 29, 2016, 10:48 a.m.
Right Patch Set: For comment 22 and 23
Created Dec. 2, 2016, 2:22 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Issue 2487 - Introduce fail2ban module
Patch Set 3:
Patch Set 4: Issue 2487 - Introduce fail2ban module
Patch Set 5: Issue 2487 - Introduce fail2ban module
Patch Set 6: Issue 2487 - Introduce fail2ban module
Patch Set 7: Issue 2487 - Introduce fail2ban module
Patch Set 8: For comments 18 and 19
Patch Set 9: For comment 22 and 23
Right:
Patch Set 1: None
Patch Set 2: Issue 2487 - Introduce fail2ban module
Patch Set 3:
Patch Set 4: Issue 2487 - Introduce fail2ban module
Patch Set 5: Issue 2487 - Introduce fail2ban module
Patch Set 6: Issue 2487 - Introduce fail2ban module
Patch Set 7: Issue 2487 - Introduce fail2ban module
Patch Set 8: For comments 18 and 19
Patch Set 9: For comment 22 and 23
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
modules/fail2ban/manifests/filter.pp
modules/fail2ban/manifests/init.pp
modules/fail2ban/templates/filter.erb
modules/fail2ban/templates/jail.erb
modules/private-stub/hiera/base.yaml
Left:
Side by side diff
|
Download
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« modules/fail2ban/manifests/init.pp
('k') |
modules/fail2ban/templates/jail.erb »
('j') |
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
1 [Definition]
1 [Definition]
2
failregex = <% @
failregex
.each do |regex| -%>
2
failregex = <% @
regexes
.each do |regex| -%>
3 <%= regex %>
3 <%= regex %>
4 <% end -%>
4 <% end -%>
LEFT
RIGHT
« modules/fail2ban/manifests/init.pp
('k') |
modules/fail2ban/templates/jail.erb »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 29364214: Issue 2487 - Introduce fail2ban module (Closed)
Created Nov. 24, 2016, 3:09 p.m. by f.lopez
Modified Dec. 5, 2016, 9:37 a.m.
Reviewers: mathias, f.nicolaisen
Base URL:
Comments: 109
This is Rietveld