modules/fail2ban/templates/jail.erb - Issue 29364214: Issue 2487 - Introduce fail2ban module

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: modules/fail2ban/templates/jail.erb

Issue 29364214: Issue 2487 - Introduce fail2ban module (Closed)

Left Patch Set: Issue 2487 - Introduce fail2ban module Created Nov. 29, 2016, 12:44 p.m.

Right Patch Set: For comment 22 and 23 Created Dec. 2, 2016, 2:22 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <% @jail_config.each do \|name, config\| -%>	1 <% @jails.each do \|name, config\| -%>

2 <% if !config['logpath'].empty? -%>	2 <% if !config['logpath'].empty? -%>
mathias 2016/11/29 13:21:27 Why this condition? And why just silently ignoring Why this condition? And why just silently ignoring the current item if it does not evaluate to true? f.lopez 2016/12/01 09:13:50 The path to the log file is necessary so fail2ban Show quoted text On 2016/11/29 13:21:27, mathias wrote: > Why this condition? And why just silently ignoring the current item if it does > not evaluate to true? The path to the log file is necessary so fail2ban know where to look and I don't think there is a good default here, so if the path is not given fail2ban won't start, I'll add an error in order to let the user know.
3 [<%= name %>]	3 [<%= name %>]

	4 <% if config['filter'].empty? -%>

4 filter = <%= name %>	5 filter = <%= name %>
mathias 2016/11/29 13:21:26 The filter should be an extra parameter of the cur The filter should be an extra parameter of the current config item, only defaulting to the jail name. Otherwise one cannot re-use filter definitions, or utilize vanilla ones. f.lopez 2016/12/01 09:13:50 Acknowledged. Show quoted text On 2016/11/29 13:21:26, mathias wrote: > The filter should be an extra parameter of the current config item, only > defaulting to the jail name. Otherwise one cannot re-use filter definitions, or > utilize vanilla ones. Acknowledged.
	6 <% end -%>

5 <% configuration = scope.function_merge(@jail_default, config) -%>	7 <% configuration = scope.function_merge(@jail_default, config) -%>

6 <% configuration.each do \|key, value\| -%>	8 <% configuration.each do \|key, value\| -%>

7 <%= key %> = <%= value %>	9 <%= key %> = <%= value %>

8 <% end %>	10 <% end %>

	11 <% else -%>

	12 <% raise Puppet::Error, "Log path missing from configuration" -%>

9 <% end -%>	13 <% end -%>

10 <% end -%>	14 <% end -%>

11	15

LEFT	RIGHT