Issue 2487 - Introduce fail2ban module

modules/fail2ban/manifests/filter.pp

 # == Type: fail2ban::filter
 #
 # Manage filter information and files for any custom filter.
 #
 # == Parameters:
 #
 # [*regexes*]
 #   Array of strings containing the regular expressions applied to
 #   the filter.
 #
@@ skipping 12 matching lines @@
 #
 define fail2ban::filter (
   $regexes = [],
   $ensure = 'present',
 ) {
 
   include fail2ban
   include stdlib
 
   if (size($regexes) == 0) and ($ensure == 'present') {
-    fail("An array of one or more regular expressions is needed if you want",
-          "to create a filter file.")

[mathias, 2016/12/01 09:28:30]

Please do not personalized messages ("you"). There is also no necessity to be
*that* verbose, but well.

[f.lopez, 2016/12/01 10:16:04]

Acknowledged.

+    fail("An array of one or more regular expressions is needed.")
   }
 
-  file {"/etc/fail2ban/filter.d/$title.conf":

[mathias, 2016/12/01 09:28:30]

Please use $name (and document that this parameter is used to compose the file
name).

[f.lopez, 2016/12/01 10:16:04]

Acknowledged.

+  # The $name parameter is used to compose the file name.
+  file {"/etc/fail2ban/filter.d/$name.conf":
     ensure => $ensure,
     content => template("fail2ban/filter.erb"),
     group => 'root',
     mode => '0644',
     owner => 'root',
     require => Package['fail2ban'],
     notify => Service['fail2ban'],
   }
 }