Noissue - Create first versioned copies of /filters

Noissue - Create first versioned copies of /filters

[saroyanm, 2016-11-28 11:46:53]

On 2016/11/25 08:23:24, Felix Dahlke wrote:

This review contains duplications I think we need to separate common strings
into separate files, I can see 2 ways that we can do it:
* Convert pages into .TMPL files and use get_string method 
* Make get_string method available in .html and .md files as well
I would be in favor of 2-nd approach, I'll align with Vasily to understand how
much effort it will require to implement that feature, after that I can help you
to upload the new patch if you can make me a collaborator, new patch will
contain, common strings separation, more meaningful IDs and descriptions if
required.

Can you please let me know how urgent is this change and if we have a deadline
for that.

[Wladimir Palant, 2016-11-28 14:49:56]

On 2016/11/28 11:46:53, saroyanm wrote:
> This review contains duplications I think we need to separate common strings
> into separate files, I can see 2 ways that we can do it:
> * Convert pages into .TMPL files and use get_string method 
> * Make get_string method available in .html and .md files as well

This definitely isn't the idea. Please see the discussion under
https://intraforum.adblockplus.org/t/versioning-adblockplus-org-filters/1333/ -
we are archiving these versions for historical reasons, and creating them should
be simple. We don't care about the duplication because touching old versions
after they have been created isn't supposed to happen. If anything, we should
discuss whether we will communicate it to translators like that as well - or
whether we rely on Crowdin to make "translating" duplicates easier (personally,
I'd prefer the former, maybe combined with not even uploading historical
versions).

[saroyanm, 2016-11-28 17:09:09]

On 2016/11/28 14:49:56, Wladimir Palant wrote:
> On 2016/11/28 11:46:53, saroyanm wrote:
> > This review contains duplications I think we need to separate common strings
> > into separate files, I can see 2 ways that we can do it:
> > * Convert pages into .TMPL files and use get_string method 
> > * Make get_string method available in .html and .md files as well
> 
> This definitely isn't the idea. Please see the discussion under
> https://intraforum.adblockplus.org/t/versioning-adblockplus-org-filters/1333/
-
> we are archiving these versions for historical reasons, and creating them
should
> be simple. We don't care about the duplication because touching old versions
Acknowledged
> after they have been created isn't supposed to happen. If anything, we should
> discuss whether we will communicate it to translators like that as well - or
> whether we rely on Crowdin to make "translating" duplicates easier
(personally,
> I'd prefer the former, maybe combined with not even uploading historical
> versions).
Okey, so as far as I understand: 
* I need to ask Tamara to keep old translations for versioned pages and do not
approve any changes to them.
* Meanwhile create a ticket/align with CMS team and find solution to mark pages
that shouldn't be uploaded to the crowdin.

[Felix Dahlke, 2016-11-30 13:21:28]

On 2016/11/28 17:09:09, saroyanm wrote:
> On 2016/11/28 14:49:56, Wladimir Palant wrote:
> > On 2016/11/28 11:46:53, saroyanm wrote:
> > > This review contains duplications I think we need to separate common
strings
> > > into separate files, I can see 2 ways that we can do it:
> > > * Convert pages into .TMPL files and use get_string method 
> > > * Make get_string method available in .html and .md files as well
> > 
> > This definitely isn't the idea. Please see the discussion under
> >
https://intraforum.adblockplus.org/t/versioning-adblockplus-org-filters/1333/
> -
> > we are archiving these versions for historical reasons, and creating them
> should
> > be simple. We don't care about the duplication because touching old versions
> Acknowledged
> > after they have been created isn't supposed to happen. If anything, we
should
> > discuss whether we will communicate it to translators like that as well - or
> > whether we rely on Crowdin to make "translating" duplicates easier
> (personally,
> > I'd prefer the former, maybe combined with not even uploading historical
> > versions).
> Okey, so as far as I understand: 
> * I need to ask Tamara to keep old translations for versioned pages and do not
> approve any changes to them.
> * Meanwhile create a ticket/align with CMS team and find solution to mark
pages
> that shouldn't be uploaded to the crowdin.

I would say we should first try and see how well the "the same source string
shouldn't be translated in two different ways" approach Wladimir hinted at is
going to work for us, because then we can treat these as independent strings on
the website and it will just work :)

[saroyanm, 2016-11-30 16:04:20]

On 2016/11/30 13:21:28, Felix Dahlke wrote:
> On 2016/11/28 17:09:09, saroyanm wrote:
> > On 2016/11/28 14:49:56, Wladimir Palant wrote:
> > > On 2016/11/28 11:46:53, saroyanm wrote:
> > > > This review contains duplications I think we need to separate common
> strings
> > > > into separate files, I can see 2 ways that we can do it:
> > > > * Convert pages into .TMPL files and use get_string method 
> > > > * Make get_string method available in .html and .md files as well
> > > 
> > > This definitely isn't the idea. Please see the discussion under
> > >
> https://intraforum.adblockplus.org/t/versioning-adblockplus-org-filters/1333/
> > -
> > > we are archiving these versions for historical reasons, and creating them
> > should
> > > be simple. We don't care about the duplication because touching old
versions
> > Acknowledged
> > > after they have been created isn't supposed to happen. If anything, we
> should
> > > discuss whether we will communicate it to translators like that as well -
or
> > > whether we rely on Crowdin to make "translating" duplicates easier
> > (personally,
> > > I'd prefer the former, maybe combined with not even uploading historical
> > > versions).
> > Okey, so as far as I understand: 
> > * I need to ask Tamara to keep old translations for versioned pages and do
not
> > approve any changes to them.
> > * Meanwhile create a ticket/align with CMS team and find solution to mark
> pages
> > that shouldn't be uploaded to the crowdin.
> 
> I would say we should first try and see how well the "the same source string
> shouldn't be translated in two different ways" approach Wladimir hinted at is
> going to work for us, because then we can treat these as independent strings
on
> the website and it will just work :)

Acknowledged

[saroyanm, 2016-11-30 16:05:09]

Thanks @Wladimir and @Felix for the information, just 2 comments so far.

https://codereview.adblockplus.org/29364426/diff/29364427/locales/de/filters-...
File locales/de/filters-2.6.12.json (right):

https://codereview.adblockplus.org/29364426/diff/29364427/locales/de/filters-...
locales/de/filters-2.6.12.json:6: "message": "Die aktuellen Versionen von
Adblock Plus ermöglichen es, die Filter auf vielerlei Weise zu optimieren. Hier
wird nun erklärt, welche Möglichkeiten zur Verfügung stehen und wofür man sie
nutzen kann."
Detail: The description fields are missing, maybe we can mark the strings as
"backup" in the description ? I assume you are using a script to generate this
translations.

https://codereview.adblockplus.org/29364426/diff/29364427/locales/de/filters-...
locales/de/filters-2.6.12.json:6: "message": "Die aktuellen Versionen von
Adblock Plus ermöglichen es, die Filter auf vielerlei Weise zu optimieren. Hier
wird nun erklärt, welche Möglichkeiten zur Verfügung stehen und wofür man sie
nutzen kann."
Detail: The order of the strings are different than in "v2.7.1" and "v8". I
think it's again related to the script ?
Different order makes it really hard to compare/review the strings. Should I
rely on the script ? Or you want me to still compare them ?

[juliandoucette, 2017-12-11 16:34:38]

I'm losing faith in you Felix. Perhaps you should tap out and create an issue?