Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(182)

Issue 29364443: Issue 4653 - Add handling for bookmarks to readMetadata (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by Jon Sonesen
Modified:
2 years, 8 months ago
Visibility:
Public.

Description

Issue 4653 - Add handling for bookmarks to readMetadata Repository: hg.adblockplus.org/sitescripts

Patch Set 1 : #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M sitescripts/extensions/utils.py View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Jon Sonesen
2 years, 9 months ago (2016-11-25 10:52:53 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29364443/diff/29364529/sitescripts/extensions/utils.py File sitescripts/extensions/utils.py (right): https://codereview.adblockplus.org/29364443/diff/29364529/sitescripts/extensions/utils.py#newcode210 sitescripts/extensions/utils.py:210: metadata = self.readMetadata(self.revision) I think this logic belongs into ...
2 years, 9 months ago (2016-11-25 13:01:56 UTC) #2
Jon Sonesen
https://codereview.adblockplus.org/29364443/diff/29364529/sitescripts/extensions/utils.py File sitescripts/extensions/utils.py (right): https://codereview.adblockplus.org/29364443/diff/29364529/sitescripts/extensions/utils.py#newcode210 sitescripts/extensions/utils.py:210: metadata = self.readMetadata(self.revision) On 2016/11/25 13:01:56, Sebastian Noack wrote: ...
2 years, 9 months ago (2016-11-25 13:05:01 UTC) #3
Sebastian Noack
LGTM https://codereview.adblockplus.org/29364443/diff/29364529/sitescripts/extensions/utils.py File sitescripts/extensions/utils.py (right): https://codereview.adblockplus.org/29364443/diff/29364529/sitescripts/extensions/utils.py#newcode210 sitescripts/extensions/utils.py:210: metadata = self.readMetadata(self.revision) On 2016/11/25 13:05:01, Jon Sonesen ...
2 years, 9 months ago (2016-11-25 13:40:29 UTC) #4
Vasily Kuznetsov
2 years, 9 months ago (2016-11-25 13:47:24 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5