Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/JsContext.h

Issue 29365532: Issue #3594 - Remove `globalJsObject` and add `GetGlobalObject()` (Closed)
Left Patch Set: Created Nov. 28, 2016, 2:05 p.m.
Right Patch Set: nit fix Created Nov. 30, 2016, 5:59 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « include/AdblockPlus/JsEngine.h ('k') | src/JsContext.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 10 matching lines...) Expand all
21 #include <v8.h> 21 #include <v8.h>
22 #include <AdblockPlus/JsEngine.h> 22 #include <AdblockPlus/JsEngine.h>
23 23
24 namespace AdblockPlus 24 namespace AdblockPlus
25 { 25 {
26 class JsContext 26 class JsContext
27 { 27 {
28 public: 28 public:
29 explicit JsContext(const JsEnginePtr jsEngine); 29 explicit JsContext(const JsEnginePtr jsEngine);
30 30
31 v8::Local<v8::Context> GetV8Context() const
32 {
33 return context;
34 }
35
31 private: 36 private:
32 const v8::Locker locker; 37 const v8::Locker locker;
33 const v8::Isolate::Scope isolateScope; 38 const v8::Isolate::Scope isolateScope;
34 const v8::HandleScope handleScope; 39 const v8::HandleScope handleScope;
40 const v8::Local<v8::Context> context;
35 const v8::Context::Scope contextScope; 41 const v8::Context::Scope contextScope;
36 }; 42 };
37 } 43 }
38 44
39 #endif 45 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld