Unified Diff: include/AdblockPlus/JsEngine.h
Issue 29365532:
Issue #3594 - Remove `globalJsObject` and add `GetGlobalObject()` (Closed)
Patch Set: use JsContext
Created Nov. 28, 2016, 5:47 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
src/JsContext.h » ('j')
|
src/JsEngine.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: include/AdblockPlus/JsEngine.h |
| =================================================================== |
| --- a/include/AdblockPlus/JsEngine.h |
| +++ b/include/AdblockPlus/JsEngine.h |
| @@ -253,6 +253,8 @@ |
| private: |
| explicit JsEngine(const ScopedV8IsolatePtr& isolate); |
| + JsValuePtr GetGlobalObject(); |
| + |
| /// Isolate must be disposed only after disposing of all objects which are |
| /// using it. |
| ScopedV8IsolatePtr isolate; |
| @@ -262,7 +264,6 @@ |
| LogSystemPtr logSystem; |
| std::unique_ptr<v8::Persistent<v8::Context>> context; |
| EventMap eventCallbacks; |
| - JsValuePtr globalJsObject; |
| }; |
| } |
« no previous file with comments
|
« no previous file
|
src/JsContext.h » ('j')
|
src/JsEngine.cpp » ('J')
