Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: templates/manifest.json.tmpl

Issue 29365583: Issue 4670 - Add a new build type for Gecko-based WebExtensions (Closed) Base URL: https://hg.adblockplus.org/buildtools
Patch Set: Updated the way options page is specified in the manifest Created Nov. 30, 2016, 1:23 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« templates/chromeInfo.js.tmpl ('K') | « templates/chromeInfo.js.tmpl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* This Source Code Form is subject to the terms of the Mozilla Public 1 /* This Source Code Form is subject to the terms of the Mozilla Public
2 * License, v. 2.0. If a copy of the MPL was not distributed with this 2 * License, v. 2.0. If a copy of the MPL was not distributed with this
3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ 3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
4 4
5 { 5 {
6 "manifest_version": 2, 6 "manifest_version": 2,
7 {%- if releaseBuild %} 7 {%- if releaseBuild %}
8 "name": "__MSG_name__", 8 "name": "__MSG_name__",
9 {%- else %} 9 {%- else %}
10 "name": "__MSG_name_devbuild__", 10 "name": "__MSG_name_devbuild__",
11 {%- endif %} 11 {%- endif %}
12 12
13 "short_name": "__MSG_name__", 13 "short_name": "__MSG_name__",
14 "description": "__MSG_description__", 14 "description": "__MSG_description__",
15 "default_locale": "en_US", 15 "default_locale": "en_US",
16 "version": {{version|json}}, 16 "version": {{version|json}},
17 "author": {{metadata.get('general', 'author')|json}}, 17 "author": {{metadata.get('general', 'author')|json}},
18 18
19 {%- if metadata.has_section('compat') and metadata.has_option('compat', 'chrom e') %} 19 {%- if metadata.has_section('compat') and metadata.has_option('compat', 'chrom e') %}
20 "minimum_chrome_version": {{metadata.get('compat', 'chrome')|json}}, 20 "minimum_chrome_version": {{metadata.get('compat', 'chrome')|json}},
21 {%- endif %} 21 {%- endif %}
22 22
23 {%- if metadata.has_section('compat') and metadata.has_option('compat', 'edge' ) %} 23 {%- if metadata.has_section('compat') and metadata.has_option('compat', 'edge' ) %}
24 "minimum_edge_version": {{metadata.get('compat', 'edge')|json}}, 24 "minimum_edge_version": {{metadata.get('compat', 'edge')|json}},
25 {%- endif %} 25 {%- endif %}
26 26
27 {%- if type == 'gecko-webext' %}
28 "applications":
29 {
30 "gecko":
31 {
32 "id": {{metadata.get('general', 'id')|json}}
33 {%- if metadata.has_section('compat') and metadata.has_option('compat', 'g ecko') %}
Sebastian Noack 2016/12/01 16:24:54 If I understand correctly this will result into a
Wladimir Palant 2016/12/01 21:39:32 It doesn't matter because this JSON file is being
34 ,
35 "strict_min_version": {{metadata.get('compat', 'gecko')|json}}
36 {%- endif %}
37 }
38 },
39 {%- endif %}
40
27 {%- if pageAction %} 41 {%- if pageAction %}
28 "page_action": { 42 "page_action": {
29 "default_icon": {{pageAction.icon|json}}, 43 "default_icon": {{pageAction.icon|json}},
30 {%- if pageAction.popup %} 44 {%- if pageAction.popup %}
31 "default_popup": {{pageAction.popup|json}}, 45 "default_popup": {{pageAction.popup|json}},
32 {%- endif %} 46 {%- endif %}
33 "default_title": "__MSG_name__" 47 "default_title": "__MSG_name__"
34 }, 48 },
35 {%- endif %} 49 {%- endif %}
36 50
(...skipping 20 matching lines...) Expand all
57 {%- endif %} 71 {%- endif %}
58 72
59 {%- if backgroundScripts %} 73 {%- if backgroundScripts %}
60 "background": { 74 "background": {
61 "scripts": {{backgroundScripts|json}}, 75 "scripts": {{backgroundScripts|json}},
62 "persistent": true 76 "persistent": true
63 }, 77 },
64 {%- endif %} 78 {%- endif %}
65 79
66 {%- if metadata.has_option('general', 'options') %} 80 {%- if metadata.has_option('general', 'options') %}
67 "options_page": {{metadata.get('general', 'options')|json}}, 81 "options_ui": {
Sebastian Noack 2016/12/01 16:24:54 Did you test whether this is supported on Microsof
Wladimir Palant 2016/12/01 21:39:31 You are right, it doesn't. So fallback it is.
82 "page": {{metadata.get('general', 'options')|json}},
83 "open_in_tab": true
84 },
68 {%- endif %} 85 {%- endif %}
69 86
70 {%- if metadata.has_option('general', 'devtools') %} 87 {%- if metadata.has_option('general', 'devtools') %}
71 "devtools_page": {{metadata.get('general', 'devtools')|json}}, 88 "devtools_page": {{metadata.get('general', 'devtools')|json}},
72 {%- endif %} 89 {%- endif %}
73 90
74 {%- if contentScripts %} 91 {%- if contentScripts %}
75 "content_scripts": {{contentScripts|json}}, 92 "content_scripts": {{contentScripts|json}},
76 {%- endif %} 93 {%- endif %}
77 94
78 {%- if webAccessible %} 95 {%- if webAccessible %}
79 "web_accessible_resources": {{webAccessible|json}}, 96 "web_accessible_resources": {{webAccessible|json}},
80 {%- endif %} 97 {%- endif %}
81 98
82 {%- if metadata.has_option('general', 'managedStorageSchema') %} 99 {%- if metadata.has_option('general', 'managedStorageSchema') %}
83 "storage": { 100 "storage": {
84 "managed_schema": {{metadata.get('general', 'managedStorageSchema')|json}} 101 "managed_schema": {{metadata.get('general', 'managedStorageSchema')|json}}
85 }, 102 },
86 {%- endif %} 103 {%- endif %}
87 104
88 "_dummy": false 105 "_dummy": false
89 } 106 }
OLDNEW
« templates/chromeInfo.js.tmpl ('K') | « templates/chromeInfo.js.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld