Issue 4670 - Add a new build type for Gecko-based WebExtensions

build.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import os
 import sys
 import re
 import subprocess
 import shutil
 import buildtools
@@ skipping 177 matching lines @@
             kwargs['keyFile'] = value
         elif option in {'-m', '--multi-compartment'} and type == 'gecko':
             kwargs['multicompartment'] = True
         elif option in {'-r', '--release'}:
             kwargs['releaseBuild'] = True
     if len(args) > 0:
         kwargs['outFile'] = args[0]
 
     if type == 'gecko':
         import buildtools.packagerGecko as packager
-    elif type == 'chrome' or type == 'gecko-webext':

[Sebastian Noack, 2016/12/01 16:24:54]

How about |type in {'chrome', 'gecko-webext'}|?

[Wladimir Palant, 2016/12/01 21:39:31]

Done.

+    elif type in {'chrome', 'gecko-webext'}:
         import buildtools.packagerChrome as packager
     elif type == 'safari':
         import buildtools.packagerSafari as packager
     elif type == 'edge':
         import buildtools.packagerEdge as packager
 
     packager.createBuild(baseDir, type=type, **kwargs)
 
 
 def runAutoInstall(baseDir, scriptName, opts, args, type):
@@ skipping 38 matching lines @@
 def readLocaleConfig(baseDir, type, metadata):
     if type == 'gecko':
         import buildtools.packagerGecko as packager
         localeDir = packager.getLocalesDir(baseDir)
         localeConfig = {
             'name_format': 'BCP-47',
             'file_format': 'gecko-dtd',
             'target_platforms': {'gecko'},
             'default_locale': packager.defaultLocale
         }
-    elif type == 'chrome' or type == 'gecko-webext':
+    elif type in {'chrome', 'gecko-webext'}:
         import buildtools.packagerChrome as packager
         localeDir = os.path.join(baseDir, '_locales')
         localeConfig = {
             'name_format': 'ISO-15897',
             'file_format': 'chrome-json',
             'target_platforms': {'chrome'},
             'default_locale': packager.defaultLocale,
         }
     else:
         localeDir = os.path.join(
@@ skipping 330 matching lines @@
                 if option in ('-h', '--help'):
                     usage(scriptName, type, command)
                     sys.exit()
             commands[command](baseDir, scriptName, opts, args, type)
         else:
             print 'Command %s is not supported for this application type' % command
             usage(scriptName, type)
     else:
         print 'Command %s is unrecognized' % command
         usage(scriptName, type)